Spectrum

Spectrum

Mods
2M Downloads

ItemStack aware recipe remainders deleted

Linguardium opened this issue ยท 2 comments

commented

Spectrum/src/main/java/de/dafuqs/spectrum/blocks/pedestal/PedestalBlockEntity.java

Line 603 in 084703c

Item recipeReminderItem = itemStack.getItem().getRecipeRemainder();

I would recommend calling the injected ItemStack getRecipeRemainder(ItemStack stack) method instead of the vanilla one, to ensure you dont accidentally start wiping out items.

https://github.com/FabricMC/fabric/blob/1.19.2/fabric-item-api-v1/src/main/java/net/fabricmc/fabric/api/item/v1/FabricItem.java#L33C70-L33C70

commented

also affects fabrication chest and likely anything else that uses the InventoryHelper method

Spectrum/src/main/java/de/dafuqs/spectrum/helpers/InventoryHelper.java

Line 311 in 8d33b79

Item remainder = currentStack.getItem().getRecipeRemainder();

commented

Absolutely. Pretty sure that code is back from 1.17.1 even, when that method did not even exist. Will do