Spectrum

Spectrum

2M Downloads

[BUG] Doomblooms are unfarmable / We need primordial fire immunity

Azzyypaaras opened this issue ยท 2 comments

commented

Describe the bug
When we created primordial fire, we really didn't stop and think about stuff that should be immune to it. It made enough sense at a time since the answer is that nothing should be but uh. Well.

Doomblooms spread their seeds by exploding. This explosion creates a raging inferno of... primordial fire...

...which the seeds are right in the middle off. And which they are not immune to.

To Reproduce
Grow a doombloom, blow it up, and watch as the seeds you worked so hard for are consume by the raging rancor of their mother.

Suggestion Going Forward
We should set up a system to mark certain items as immune to primordial fire. Additionally, we should probably make a tag for immunity as well.

Mod version
1.7.0

Screenshots
image

Notes
You know, annoying as this may be I am quite pleased to see this be the only issue with PF so far.

commented

What a nice bug report. This one will be fun. Soooo:

  • I can confirm the bug in the final release
  • Alpha versions do not seem to have that issue. I could throw Doombloom Seeds into Primordial Fire without them burning up no problem.

=> It looks like the issue was introduced right at release. Smh no proper testing. Lazy modders.

Good thing Spectrum has a system in place to make certain items immune to specific forms of damage:

SpectrumItemStackDamageImmunities.addImmunity(SpectrumItems.DOOMBLOOM_SEED, DamageSource.IN_FIRE);

But wait... Doombloom seeds are marked to be immune to being on fire. So since items with "on fire" immunity have their item entities marked as fireproof

private void isFireProof(CallbackInfoReturnable<Boolean> callbackInfoReturnable) {

they totally should not burn up in primordial fire, right?

Someone must have made stuff immune to fire still take damage by primordial fire. Who could it have been?? I's a mystery ๐Ÿค” ๐Ÿค” ๐Ÿค”

commented

Skill issued โœ