Spectrum

Spectrum

2M Downloads

[BUG] Most blocks do not have a MapColor defined (1.20.1)

unilock opened this issue ยท 2 comments

commented

Describe the bug
Most of the blocks registered by Spectrum do not define a MapColor.

To Reproduce
N/A

Expected behavior
The blocks have a MapColor defined via the FabricBlockSettings builder.

Mod version
1.7.2

Screenshots
N/A

Crash Report
N/A

Additional context
In 1.19.2, this was handled by FabricBlockSettings.of(Material.<base material>) (e.g. Material.AMETHYST for gemstone storage blocks and Material.STONE for Polished Basalt and Calcite), which would copy all settings of a previously defined (vanilla) block, including its MapColor.

However, the Material enum no longer exists on 1.20 for absolutely no good reason, so MapColors must be defined via FabricBlockSettings.create().mapColor(DyeColor.<color>) or .mapColor(MapColor.<color>) (as some other blocks already have done).

For comparison, the gemstone storage block settings definition in:
1.19.2
1.20.1

For context, I believe the lack of a MapColor defined for each block is the cause of the following issue present in the Xaero's Minimap / Xaero's World Map mods:
image

commented

Some info on why the issue isn't on my end:
My mods check for the existence of vanilla map colors because they are required for the optional vanilla color mode.
If some blocks in this mod don't have map colors defined, then they also don't show up on vanilla maps, so the problem goes beyond my map mods.

commented

Very much agreed, yes.