Spectrum

Spectrum

Mods
2M Downloads

enchantments are always valid

Linguardium opened this issue ยท 1 comments

commented

Spectrum/src/main/java/de/dafuqs/spectrum/mixin/EnchantmentMixin.java

Line 15 in c8393b3

if (!cir.getReturnValue() || (stack.getItem() instanceof ExtendedEnchantable extendedEnchantable && extendedEnchantable.acceptsEnchantment((Enchantment) (Object) this))) {

looks like some broken logic here.

effectively says: if original value == false, return true

commented

Looking at commit history this change was specifically made to fix #298
Maybe the best solution is to just drop cir.getReturnValue()?