Describe the bug
Enchant loyalty and other unacceptable enchantments on twinsword by separating them.

To Reproduce
Separate twinsword to talons.
Enchant both talons with enchantments like loyalty and impaling (mostly trident enchantments).
Combine them as twinsword.

Expected behavior
Either make twinsword support these enchantments or make these enchantments not available to talons.
Perhaps there is a better solution?

Minecraft version
1.20.1

Mod version
1.8.4

Screenshots

My bugfix PR (#674) makes Loyalty a valid twinsword enchantment, since it actually works totally fine. (not anymore) Not sure about Impaling, though.

Wait it does? I missed that.

Why is a feature change on a bugfix PR?

TranstargetItem has been fixed, fix is now included in the aforementioned bugfix PR.

I thought loyalty on twinsword was "something seems amiss" because you weren't supposed to do so.

Wait it does? I missed that.

Why is a feature change on a bugfix PR?

My bugfix PR (#674) makes Loyalty a valid twinsword enchantment, since it actually works totally fine. Not sure about Impaling, though.

Double checked again, impaling and riptide can be applied to twinsword directly, but EMI didn't mention this, should I report this to the EMI's side?

Seems like this happens because something is broken in the TranstargetItem interface, which the Dragon Talon uses to take sword enchants rather than trident enchants despite being a trident internally. Currently testing to see what specifically is wrong with it.

As for being able to apply Impaling and Riptide to the twinsword - are you testing in creative mode? When you're in creative, the anvil will let you apply enchants that are not normally applicable.

Seems like this happens because something is broken in the TranstargetItem interface, which the Dragon Talon uses to take sword enchants rather than trident enchants despite being a trident internally. Currently testing to see what specifically is wrong with it.

As for being able to apply Impaling and Riptide to the twinsword - are you testing in creative mode? When you're in creative, the anvil will let you apply enchants that are not normally applicable.

Tested in survival again, you can use the same trick above to apply Impaling and Riptide to twinsword in survival.

You can use the Dragon Talon trick to apply Impaling and Riptide due to the broken TranstargetItem, which is now fixed in a PR. However, you previously mentioned being able to apply them directly to the twinsword itself. As far as I can tell this is not currently possible - were you actually referring to the Dragon Talon thing?

You can use the Dragon Talon trick to apply Impaling and Riptide due to the broken TranstargetItem, which is now fixed in a PR. However, you previously mentioned being able to apply them directly to the twinsword itself. As far as I can tell this is not currently possible - were you actually referring to the Dragon Talon thing?

My mistake, I tested them in creative mode. Sorry for the confusion.