Spell Power Attributes [Fabric]

Spell Power Attributes [Fabric]

11M Downloads

[1.20.1] Wrong behaviour ADD and MULTIPLY Operation in enchantments configuration

BazeBro1337 opened this issue ยท 4 comments

commented

I have noticed that these types of enchantment power applications are not working correctly. It is also impossible to use vanilla armor, weapons from mods that support Spell Power (like Simply swords).

This formula is correct.
Image

In the enchantment configuration Operation property value is "ADD".
Image

But at the same time, multiplication always occurs.

No armor/enchants
Image

Full Sunfire V set (0 * value * level = 0)
Image

I think it's because the mod's initialization uses multiplication for all schools of magic with the POWER trait (arcane, fire, frost, etc.). Operation parameter in enchantment configuration does nothing, changing it doesn't affect anything.
Image

commented

The enchantment system on this legacy version is underdeveloped, due to the limitations of the old game version.
There is no development capacity to backport the new enchantment system of the game introduced on 1.21.

commented

How does the enchantment system differ for version 1.21?

commented

Completely rewritten, data driven, fully supporting attribute modifiers.

The tooltip shown on these screenshots, gives an estimated damage output. This estimation, might be buggy due to not including enchantments. But in reality damage done is increased.

commented

thanks, i will try to move my build to 1.21