Spelunkery

Describe the bug:
The game crashes during startup when Spelunkery is installed alongside Spectrum using Sinytra Connector.

Versions:
Minecraft version: 1.20.1
Spelunkery version: 0.3.5
Moonlight Lib version: 2.9.7
NeoForge version: 47.1.99

Other mods:

Cloth Config: cloth-config-11.1.118-forge.jar
Connector: Connector-1.0.0-beta.36+1.20.1.jar
Forgified Fabric API: fabric-api-0.91.0+1.10.8+1.20.1.jar
Patchouli: Patchouli-1.20.1-84-FORGE.jar
Revelationary: revelationary-1.3.7+1.20.1.jar
Spectrum: spectrum-1.7.6-deeper-down.jar
Trinkets: trinkets-3.7.1.jar

Logs:
crash-2024-02-08_17.24.33-client.txt
debug.log

To Reproduce:

Install NeoForge (or Forge 47.1.3) + Sinytra Connector + Spectrum + Spelunkery + dependencies
Start the game
The game crashes during startup

Expected behavior:
The game starts.

Screenshots:
N/A

Additional info:
The issue seems to be caused by this mixin:

Spelunkery/common/src/main/java/com/ordana/spelunkery/mixins/NetherPortalSoundMixin.java

Lines 21 to 27 in 73a8b04

    
           @Inject(method = "getSoundType", at = @At("TAIL"), cancellable = true) 
        
           private void getSoundGroupMixin(CallbackInfoReturnable<SoundType> cir){ 
        
               if (CommonConfigs.PORTAL_DESTRUCTION_SOUND.get()) { 
        
                   String blockId = BuiltInRegistries.BLOCK.getKey(this.asBlock()).getPath(); 
        
                   if (blockId.equals("nether_portal")) cir.setReturnValue(NETHER_PORTAL); 
        
               } 
        
           }

During Spectrum's block registration, it calls Block#getSoundType. This fires Spelunkery's mixin, which tries to access Spelunkery's config, which then fails to initialize itself due to Forge not having finalized its mod list yet.

I expect this would happen with any mod that calls Block#getSoundType during mod initialization, so I don't think this is a Connector / Spectrum-specific issue.

will be fixed for 0.3.6

	@Inject(method = "getSoundType", at = @At("TAIL"), cancellable = true)
	private void getSoundGroupMixin(CallbackInfoReturnable<SoundType> cir){
	if (CommonConfigs.PORTAL_DESTRUCTION_SOUND.get()) {
	String blockId = BuiltInRegistries.BLOCK.getKey(this.asBlock()).getPath();
	if (blockId.equals("nether_portal")) cir.setReturnValue(NETHER_PORTAL);
	}
	}

Share to