Spelunkery

Spelunkery

80.4k Downloads

[Suggestion] Spring Water Color Compatibility with Embeddium

Dantigator opened this issue ยท 12 comments

commented

Feature:

The latest version of embeddium concludes a pack "sodium" to make it compatible with iris and else. This will make spring water using sodium's render color and it'll turn yellow in game.
Could you just make a mod check of embeddium to solve this problem?

commented

done for 0.3.10

commented

Spring water is still yellow on 0.3.10 using the latest version of Embeddium (0.3.30).

commented

i added an exception for embeddium's namespace, report it to them

commented

Spelunkery explicitly uses a yellow spring water fluid color with Embeddium installed.

(PlatHelper.isModLoaded("sodium") || PlatHelper.isModLoaded("embeddium")) ? 0xffEED543 : 0xff43D5EE,

I cannot comment on the Sodium 0.6 alphas, but this should not be necessary for Embeddium.
When compiling a version of Spelunkery with this logic removed, there is no issue with the latest version of Embeddium for 1.20.1 (0.3.30). I tested this in a standalone instance with no additional mods installed except ModernFix (which I know does not affect fluid colors).

2024-08-17_21 04 41

commented

|| PlatHelper.isModLoaded("embeddium") was only added in the latest version, they reported this issue prior to it being added. sodium uses a different RGBA hex order for some reason, thats why the exception exists

commented

I've just tried Spelunkery 0.3.9 from CurseForge, still seems to have the correct color.

commented
commented

when i put out the next version, ill remove the exception for embeddium then i guess

commented

alright

commented

@AstralOrdana I've made a PR to solve this problem. I guess this will work. https://github.com/Dantigator/Spelunkery

commented

Embeddium doesn't render as sodium does(just using vanilla color 0xff43D5EE), but it includes a pack(only name just the same as sodium) to make it compatible with other mods(like iris, sodium extra). So it will using sodium's render color(yellow 0xffEED543).

commented

Personally, I would remove the Sodium check on Spelunkery's side entirely. It should not be content mods' job to be working around performance mods aside from exceptional circumstances where it's impossible to support a use case cleanly. Fluid colors are well standardized.