[Suggestion] Spring Water Color Compatibility with Embeddium
Dantigator opened this issue ยท 12 comments
Feature:
The latest version of embeddium concludes a pack "sodium" to make it compatible with iris and else. This will make spring water using sodium's render color and it'll turn yellow in game.
Could you just make a mod check of embeddium to solve this problem?
Spring water is still yellow on 0.3.10 using the latest version of Embeddium (0.3.30).
Spelunkery explicitly uses a yellow spring water fluid color with Embeddium installed.
I cannot comment on the Sodium 0.6 alphas, but this should not be necessary for Embeddium.
When compiling a version of Spelunkery with this logic removed, there is no issue with the latest version of Embeddium for 1.20.1 (0.3.30). I tested this in a standalone instance with no additional mods installed except ModernFix (which I know does not affect fluid colors).
|| PlatHelper.isModLoaded("embeddium")
was only added in the latest version, they reported this issue prior to it being added. sodium uses a different RGBA hex order for some reason, thats why the exception exists
I've just tried Spelunkery 0.3.9 from CurseForge, still seems to have the correct color.
@Dantigator ??
when i put out the next version, ill remove the exception for embeddium then i guess
@AstralOrdana I've made a PR to solve this problem. I guess this will work. https://github.com/Dantigator/Spelunkery
Embeddium doesn't render as sodium does(just using vanilla color 0xff43D5EE), but it includes a pack(only name just the same as sodium) to make it compatible with other mods(like iris, sodium extra). So it will using sodium's render color(yellow 0xffEED543).