Spelunkery

Spelunkery

80.4k Downloads

[Mod Incompatibility] Spelunkery Ore behavior overrides Spectrum's Resonance Enchantment

f-raZ0R opened this issue ยท 1 comments

commented

==DO NOT READ BELOW IF YOU DO NOT WANT MINOR MECHANICAL SPOILERS FOR SPECTRUM==

=

=

=

=

=

=

=

=

=

=

=

=

=

=

=

Describe the bug:
Okay, I'm going to explain what the resonance enchantment does for those who don't know. Resonance, is a lategame spectrum enchantment, which is basically a,, weird version of silk touch? It has some special drops for some blocks, the main important one being for ores. Mining an ore with resonance, will, instead of its normal drop, make the ore drop "pure" versions of itself, which are used in various recipes, and yes, as you'd expect, for ore doubling. They can be obtained through other methods too, so this incompat doesn't make them unobtainable or anything, it just affects one way of getting them.

Here is the issue though. Spelunkery, changes the drops of a bunch of ores. This has the side effect of completely overriding pure resource drops for diamonds, emeralds, lapis, and redstone. You will not get a pure resource from mining these, as they will instead drop spelunkery's respective rough variant.

There is also a second, far more minor, "issue", from mining deepslate iron/gold/coal. They will correctly drop the pure resource, but spelunkery will Also make them drop raw nuggets (and in the case of iron, occasionally magnetite). This... doesn't feel right. This second part is very very minor though, so I'm fine if only the issue with gem ores is addressed, and this is left as-is.

Versions: (although this doesn't really matter due to being a mod incompatibility)
Minecraft version: 1.20.1
Spelunkery version: 0.3.10
Moonlight Lib version: 2.12.11, because anything later is incompatible with spelunkery
Fabric API / QSL / Forge version: 0.16.3

Other mods:
Spectrum, of course, and some lib mods needed for both these mods. This is a mod incompatibility, other mods aren't really relevant here.

To Reproduce:
Have a pickaxe enchanted with resonance, and mine any vanilla ore that has its drops changed by spelunkery. If its a gem, note the lack of a pure resource, and if it's a deepslate ore, note the pure resource, and raw ore nuggets of the same ore, both dropping.

Expected behavior:
I have no clue, honestly. For the gems, spectrum should definitely take full priority and drop the pure resources. But for deepslate ores? You're either getting rid of spelunkery's mechanic here with this enchantment (which is fine,,, maybe?), or you're putting in the extra effort to add nuggets for pure resources for spectrum compat, which,,, feels like it'd then necessitate doing compat for everything else from spectrum, and that's a big ask.

commented

Fixed on Spectrum's end, at least for getting pure resources from redstone/lapis/diamond/emerald. The "pure ore + raw nuggets" thing with deepslate ores is still a thing, but that would likely require new items added for interop, so I leave what is done there up to you.