Spice of Fabric (Fabric)

Spice of Fabric (Fabric)

593k Downloads

[Bug] Polymer support checks for wrong (outdated?) mod ID

unilock opened this issue · 6 comments

commented

When use-polymer is set to true in spiceoffabric.hjson, the server crashes with Polymer is not installed, but Polymer usage is enabled in the Spice of Fabric config!, regardless of whether Polymer is installed.

I believe this is because the mod is checking for the wrong mod ID for Polymer:

if (SOFConfig.items.usePolymer) {
if (!FabricLoader.getInstance().isModLoaded("polymer")) {
LOGGER.error("Polymer is not installed, but Polymer usage is enabled in the Spice of Fabric config!");
System.exit(1);
}
SOFPolymer.init();
} else {
initNativeFoodContainerItems();
}

"polymer" should be "polymer-core".

(and/or "polymer-resource-pack", but it's technically not required, and it's unlikely that polymer-core will ever be installed standalone without polymer-resource-pack as part of a bundle)

commented

open the issue again please, this isn't fixed

commented

Thanks for reporting, it will be fixed in the next release :‌)

commented

This is still the case in the latest release for 1.20.4...

if (!FabricLoader.getInstance().isModLoaded("polymer")) {

commented

This is not fixed in 1.20.1 releases, same issue as above.

commented

Still not fixed in 1.20.4

commented

Still broken in 1.6.2+mc1.20.1 distributed on Modrinth