Spice of Fabric (Fabric)

Spice of Fabric (Fabric)

593k Downloads

[bug] extra origins mod still not compatible

TobiPeterG opened this issue ยท 2 comments

commented

Hey there,

I'm using the extra origins mod and even though I already changed the health formula to (baseHealth * 0.5) + max(2 * log2(uniqueFoodsEaten), 0) (so giving me only half of the hearts of basehealth), I start with 0.5 hearts when I start with the inchling, instead of 2.5. This might be because spiceoffabric is manipulating the health before extra origins, so spiceoffabric reduces it to 5 hearts, while extra origins then removes 5 hearts afterwards.
Spiceoffabric would therefore have to be "intialized" after origins / extra origins. Though I don't know if that is possible / a bug of this mod

EDIT: This also happens with the origins mod and any of their origin, just because they are hard coding all their health changes.

commented

I could open a pull request on these mods to "fix" this, by using a multiplier (like here) instead of a fixed value.
They would have to change the mod description on the other hand, because technically, they wouldn't start with e.g. 5 hearts less then, but 50% of the health (not making a difference normally, but in combination with this mod e.g. it does.

Alternatively, spiceoffabric would need to fix this by changing the health value after origins, as already stated.

Edit: pr open for extra-origins

commented

It looks like at least Origins is already using modifiers, but they probably come after Spice Of Fabric.
I'm not completely sure how to reliably put SoF behind Origins.