Spice of Fabric (Fabric)

Spice of Fabric (Fabric)

Mods
593k Downloads

getMaxUseTime infinite loop

spoorn opened this issue ยท 0 comments

commented

crash-2022-04-06_14.52.22-server.txt

Infinite loop when calling getMaxUseTime:

java.lang.StackOverflowError: Ticking entity
	at net.minecraft.class_1792.method_7881(class_1792.java:342)
	at net.minecraft.class_1799.method_7935(class_1799.java:538)
	at de.siphalor.spiceoffabric.util.MaxUseTimeCalculator.getMaxUseTime(MaxUseTimeCalculator.java:19)
	at net.minecraft.class_1799.handler$ehb000$getMaxUseTime(class_1799.java:11646)
	at net.minecraft.class_1799.method_7935(class_1799.java:538)
	at de.siphalor.spiceoffabric.util.MaxUseTimeCalculator.getMaxUseTime(MaxUseTimeCalculator.java:19)
	at net.minecraft.class_1799.handler$ehb000$getMaxUseTime(class_1799.java:11646)
	at net.minecraft.class_1799.method_7935(class_1799.java:538)
	at de.siphalor.spiceoffabric.util.MaxUseTimeCalculator.getMaxUseTime(MaxUseTimeCalculator.java:19)

I believe this is because this Mixin has a path that ends up calling itself again and again:

spiceoffabric/src/main/java/de/siphalor/spiceoffabric/mixin/MixinItemStack.java

Line 20 in e2e5064

public void getMaxUseTime(CallbackInfoReturnable<Integer> callbackInfoReturnable) {

Might just need to change this to stack.getItem().getMaxUseTime():

spiceoffabric/src/main/java/de/siphalor/spiceoffabric/util/MaxUseTimeCalculator.java

Line 19 in e2e5064

return stack.getMaxUseTime();