Some recipes and more specifically buildings like minecolonies which use armors on armor stands cant recognize them because of the additional nbt data thast generates. Some anvil recipe to clear modifiers would be nice or a way to blacklist specific items from generasting with bonuses on the configs would be welcome. Enjoying the mod otherwise, thanks!

Do you know why having NBT data on items would cause it to have issues with armor stands, recipes, or minecolonies? That sounds like a bug for other mods - they shouldn't be assuming there's no custom NBT data on items.

You can use lapis lazuli to reroll items and remove modifiers, but the NBT hidden data will still be there.

I can add some logic to disable items from generating bonuses though

They use schematics which are basically nbt structures and those save entity data as well in the form of armor stands so they're expecting the armor stand with the nbt data of leather armor and end up getting leather armor + nbt which gets rejected, definitely seems like something they could implement a fix for on their end potentially and I'l bring it up with them as well. Same if you try to submit an armor for their research.

On your mod's end a really simple fix could just be check if an item has a no_attribute custom tag here

I could even do a PR for this but I wanted to discuss it with you first. Thanks!

How are they handling enchantments NBT data then? Sure, I could add a check for no_attribute tag, or use a config disable list, but I'm still wondering how and why other mods would not work on my custom NBT data, but works on others. If you open an issue on their end, could you link it here?

Im pretty sure enchantment nbt will also invalidate their structure building, although I havent specifically tried it yet. Here's the issue though, ldtteam/minecolonies#8506

Even if you were able to disable certain items from having attribute NBT data on them, wouldn't you need to disable all armors you'd want to generate with minecolonies? Seems like it could be a hassle, and if players wanted to actually wear those items, it wouldn't generate attributes anymore. (Or did you mean you wanted some way to disable attribute generation for specific ItemStacks in your inventory, but that runs into this problem:)

I'd have to find a custom way to disable items from having attributes, without adding any NBT data to the item which I initially wanted to avoid as I'm trying to stick with the vanilla system as much as possible.

in this instance minecolonies only uses vanilla leather, diamond and iron/gold armors. This is not a problem in my pack specifically since those all have 10 durability and exist only for decorations anyway, so a player would never wear them. In some other minecolonies pack for instance if direworlf 20 1.18 pack which has minecolonies was to add your mod they'd run into this issue as well. Then yeah they could presumably tag those specific vanilla armors not to generate attributes and let the modded armors in that pack continue generating them.

Having a specific item stack not generate the stats could work but yeah I imagine that's a more complicated implementation

Any update on this issue? If it's something you'd rather not implement I understand but as the pack is entering beta soon
I'll have to resolve this by removing the mod most likely which would definitely be less preferable.

I believe the issue #8 is similar and raycom's PR (#9) submitted would address this nicely

yep this totally solves my issue, ty!

@Saereth I merged the PR from #9 , let me know if that mitigates your problem. Haven't had time to look into a more permanent and proper solution