[1.18.1] Some mods do not get attributes

Question

kwpugh opened this issue 3 years ago · 11 comments

kwpugh commented 3 years ago

Hi, nifty mod for Fabric.

I checked some of my weapon/tool mods with mixed results.

Gobber: Tried Gobber, Nether Gobber, and End Gobber Sword - none got attributes

Easy Emerald & More: Tried Emerald, Ruby and Steel Sword - only the Ruby Sword got attributes

More Gems: Tried Citrine, Alexandrite, Spinel, and Mossianite Swords - only Alexandrite got attributes

The latest sources for all three mods are on GitHub for reference. Feel free to stop by my Discord if you need to chat.

Regards.

Kevin

kwpugh · Answer 1 · 2022-02-25T00:56:50.000Z

I also have Mythic Metals and Tech Reborn in my test pack.

Tried Celestial, Banglum, and Bronze Swords - only Celestial got attributes. Celestial is smithed from a diamond sword. Others are crafted.

Tried Tech Reborn Peridot, Ruby, and Sapphire Swords - none got the attributes.

kwpugh · Answer 2 · 2022-02-25T01:28:05.000Z

Interestingly, the swa3 tag is on all the swords, but the tool tips don't reflect it.

kwpugh · Answer 3 · 2022-02-25T01:42:07.000Z

Also, logging in and out a few times and the tooltips on diamond go aways, although the tags appear to still be there.

spoorn · Answer 4 · 2022-02-25T02:00:12.000Z

Each attribute has a chance to apply when the weapon is added to your inventory, and only attempts it once: https://github.com/spoorn/SpoornWeaponAttributes/blob/main/config-documentation.json5#L5

The chance for each attribute to apply is rather low by default to not overpower weapons.

I'm working on adding a way to reroll attributes easily

kwpugh · Answer 5 · 2022-02-25T02:02:37.000Z

oh, every weapon does not get something. I misunderstood the concept. So it would be normal that weapons can be crafted and get nothing.

spoorn · Answer 6 · 2022-02-25T02:12:54.000Z

yes, you might get all attributes, none, or a subset. And it doesn't have to be crafted, could be looted

spoorn · Answer 7 · 2022-02-25T02:13:14.000Z

You could always set the attribute chance to 1.0 if you want to guarantee an attribute is always applied

kwpugh · Answer 8 · 2022-02-25T02:28:55.000Z

Now I understand. I was just checking to make sure it was compatible with my weapon/tool mods. Very nice work.

With mods that have expensive or rare swords, having a "re-roll" item found in chests might be a nice option.

Great work.

kwpugh · Answer 9 · 2022-02-25T02:29:30.000Z

Seems to work fine.

Thanks

spoorn · Answer 10 · 2022-02-25T03:41:26.000Z

Added a reroll mechanic in the latest revision, please try it out!

kwpugh · Answer 11 · 2022-02-25T19:21:16.000Z

Nice. I tried it out, works great. Lapis is a good choice