Spyglass Astronomy

Spyglass Astronomy

68.7k Downloads

Invisible comet?

Slimmeyy opened this issue ยท 9 comments

commented

One of the 4 comets on my seed seems to be completely invisible. It's always very close at only 0.99-1.01 AU distance at all times. I stumbled across it by accident while trying to find the 2 comets I hadn't seen yet (this was one of them). The other 3 comets are all visible when they're supposed to be.

Looking at Gamma
Comet Info

Note: the stars work like intended. I just disabled them to find the comets.

Versions:

  • Minecraft 1.20.1
  • Fabric Loader 0.15.3
  • Spyglass Astronomy 1.0.8

All other mods in use:
mods used
(also using a resource pack that makes the spyglass lens more transparent)

commented

that is weird, looking at the orbital parameters the info command is giving, the fact that its only 1 AU away must be because you caught it at its closest approach? it should spend much of its time >20 AU away

if you send me the planet seed (which you can get from one of the admin commands) i can see if i can reproduce the issue - it might just be that it generated near the lowest possible albedo of 0.125, as if it were some dark rocky asteroid

commented

looking at the code, as long as the comet is within 4 AU it should be visible from Y 255, even with the lowest possible albedo

commented

Planet seed is 6301639858448075734.
I tracked the comet's position in the sky 48 times with 1000t intervals starting from 0. I also checked it on a couple random nights throughout its 88-day orbital period, but those aren't tracked on a spreadsheet. It's always at a distance of 0.99-1.01 AU, it's always at 0% orbit completion, and it's never visible. It's by far the closest comet on this seed: the other comets have orbital periods of 514, 616 and 1104 days. It's also the closest object outright quite frequently.
image

commented

thats interesting, ill investigate shortly but my immediate thought looking at the 1 AU distance and 0% position is making me think its locked at the solar systems "0 0 0" so the variation in distance is just the slight eccentricity of thisworld - although in that case it should always appear near the sun? perhaps theres some discrepancy between rendered position and actual position

definately suspicious of some kind of null or infinity or 0 where there shouldn't be

this is a really funny bug conceptually

commented

the comet is indeed located at 0 0 0

commented

aha! its kepler's fault! (indirectly, its mostly my fault, although the kepler lookup was responsible for it not just crashing)

commented

lmao its an obvious division by 0 error

commented

image

this just straight up applies to the first comet in every world omg

commented

image
theres your missing comet! the next sga update will have 26% more comets!