Spyglass Improvements: Zoom, Quick Access... [Fabric/Forge]

Spyglass Improvements: Zoom, Quick Access... [Fabric/Forge]

8M Downloads

Conflict with Spyglass Astronomy

sternschnaube opened this issue · 3 comments

commented

java.lang.RuntimeException: Mixin transformation of net.minecraft.class_329 failed
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
at net.minecraft.class_310.(class_310.java:606)
at net.minecraft.client.main.Main.method_44604(Main.java:205)
at net.minecraft.client.main.Main.main(Main.java:51)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
... 10 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector swapTexture(ILnet/minecraft/class_2960;)V in spyglass_astronomy.mixins.json:InGameHudMixin from mod spyglass_astronomy failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap spyglass_astronomy-refmap.json
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468)
at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1385)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1052)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:400)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
... 13 more

The issue on Spyglass Astronomy: Nettakrim/Spyglass-Astronomy#8

commented

i have fixed this on my end
spyglass improvements' zoom seems to completely override mine, which is interesting but mostly fine - it does make drawing constellations directly above and below you more difficult, as spyglass improvements does not compensate for the effective reduction in horizontal sensitivity when zoomed in while looking up or down

commented

hmm 1.20 appears to have changed how spyglass overlays are rendered, making it pretty hard not to use an @Redirect, so compatibility might break again for 1.20 unless both me and the spyglass improvements dev use a more compatible injection from mixin extras like @WrapOperation (https://github.com/LlamaLad7/MixinExtras/wiki/WrapOperation)

commented

Thanks for your hard work.