Starlight (Fabric)

Starlight (Fabric)

17M Downloads

Block Lighting bugs in flat neighboring chunks

Zailer43 opened this issue ยท 4 comments

commented

Expected Behavior

When I place the light source everything lights up properly

Actual Behavior

When I place the light source, everything doesn't light up properly

Reproduction Steps

  1. Build something like this (the wall or floor must be completely flat (or at least the part where light reaches) and be on the edge of the other chunk, but the bug will not occur)
    2020-11-25_21 38 59

  2. Place a light source at least 1 block away from the wall or floor
    2020-11-25_21 30 50

Mod Version

  • starlight-0.0.1-SNAPSHOT

Additional screenshots

2020-11-24_19 41 24

5681942750785458012
/execute in minecraft:overworld run tp @s 44.39 37.57 -304.14 -112.63 -8.26
2020-11-25_21 52 41

5681942750785458012
/execute in minecraft:overworld run tp @s -955.04 25.00 88.25 68.13 9.18
2020-11-25_21 56 00

commented

I have this fixed locally, I'll push when I've refactored the skylight nibble management (yes it was just an issue where I was not calling re-rendering for neighbouring blocks, so this isn't a light corrupting issue).

commented

I don't know what's causing that from the looks of it, but I suspect it has something to do with the initialisation of block light nibbles

commented

Actually, this looks like an issue where I'm not queueing neighbour chunks to be re-rendered.