Starlight (Fabric)

Starlight (Fabric)

18M Downloads

[1.17] Light is not updated

toficzko opened this issue · 9 comments

commented

After migrating my minecraft 21w10a vanilla server to fabric with latest starlight from releases (happens when Compiled locally too) The light is getting corrupted , What i mean by that is all light sources only illuminate one block , this happens on a clean server too

Here are some screenshots:

Vanilla:
vanilla2

[NOTE:] Sometimes the light fixes itself is some entities are around it. [Screenshot 2] it fixed near the glow squids this time but it’s not always the case

Starlight :

light

[EDIT: Updated the screenshots to look like they are supposed to]

commented

Looks like #25

commented

1.0.0-RC1 has some fixes in the suspected area, can you re-test?

commented

I re-tested it now

These are the results on a vanilla client with starlight for 21w11a from releases on the server:

issue

These are the results on a fabric client with the same version of starlight , as on the server:

light

The results sadly are the same

[ I forgot to mention that the mobs spawn there because of the lightning in the issue description]

commented

And when switching back to vanilla on the server, the chunks get relighted and look like they are supposed to, with proper light

And the screenshots in the issue description , are very brightened up and i don't know why, but the other screenshots are ok , i need to update them

[EDIT: Updated]

commented

This is certainly very odd. I produced it locally and will check it out.

I'm very unsure about why this is happening on the dedicated server and not the integrated; all of my 1.17 testing has been on integrated and I never saw any of it but my first dedicated test showed it.

commented

This does not occur in 1.16.5.

commented

I see where the problem is. The block light recalculation is incorrect in 1.17, as it's not using an offset.
Given it's a snapshot build, I'll simply update the artifact in the release page.

commented

Update to the new version on the release page to fix

commented

I already Compiled the latest commit myself and the light issues are fixed , thanks