[Bug]: Unable to register name on small statue character
lSherozl opened this issue · 15 comments
General Info
- I am running a modpack
- I can reproduce this issue consistently in single-player
- I can reproduce this issue consistently in multi-player
- I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I am having the same problem.
- I am crashing and can provide my crash report(s)
- I am using the latest version of the mod
Forge version
36.2.28
Mod version
1.7.6 Latest 1.16.5 Version
Java version
Java 8 321
Issue Description
Does not show my name on the smaller player statues stature, it does show it on the bigger one, here is an image:
Additional Information
No response
What is your in-game name so I can see if I can reproduce it?
Sorry just saw this my in game name is....... ISherozI ......that is with 2 capital I's not lowercase L's
I am also playing on a modpack, better Minecraft plus, do not know if its a conflict with some mod, but the bigger statue of me works fine
I think this is an issue in 1.16 Jade. In the 1.18 version of Jade it renders the name correctly
I think this is an issue in 1.16 Jade. In the 1.18 version of Jade it renders the name correctly
So I should talk to the Jade owners?
WailaErrorOutput.txt
I happen to have the output from when I was trying to debug the issue
The code that gives the Player Statue's block it's name hasn't really changed between the 1.16 and 1.18 version
so what the error is? it should be logged in WailaErrorOutput.txt
Sorry I don't know what that is, the error is that in the picture instead of displaying my name with jade on the 1.16.5 version, it displays "Error"
I think this is the cause: https://github.com/ShyNieke/StatuesMod/blob/1.16.5/src/main/java/com/shynieke/statues/tiles/PlayerTile.java#L218-L221
I think the return value should be nonnull if you return true in hasCustomName