[๐]: Create compat missing textures & language keys
VoidLeech opened this issue ยท 5 comments
Code of Conduct
- Always check you are using the latest version of the mods and its dependencies
- Ensure the version of EveryCompat & Moonlight Lib are up to date
- Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
- If you are unsure which mod is the culprit.
Disable all of your mods and enable them 1-2 mods each time to isolate the culprit - Confirm that there is no existing issue with a similar description submitted in the list of issues.
Version - Loader (DO NOT FORGET TO SELECT THE CORRECT VERSION)
1.20.1 - FORGE
StoneZone Version
stonezone-1.20-2.7.1
Moonlight Lib Version
moonlight-1.20-2.13.41
Issue with mods
Create 0.5.1j
Certain stone mods, such as
Deeper and Darker
Quark
Naturalist
And more D:
Issue Detail
The language key is incorrect for the cut brick stairs, cut brick slab, and cut brick wall, the actual id has brick
, not bricks
:
StoneZone/common/src/main/resources/assets/stonezone/lang/en_us.json
Lines 25 to 27 in aa0765d
Certain block variants (not all) for stone types from certain mods (not all) will have missing textures for some of their faces:
The only such cases I encountered were when the stone mod already added a:
- TYPE_pillar (the layered_TYPE would then miss its top and bottom faces)
- cut_TYPE_slab (the polished_cut_TYPE_slab would then miss its side faces)
But I assume there might be more scenarios where one stonezone block uses the textures generated from a different stonezone block that didn't get registered because the stone mod already has a block matching that name pattern.
OPTIONAL: Latest.log | Crash-report Attachment
No response
OPTIONAL: To Produce
No response
Yep textures are fixed. Looks like a c/stone_mod/type_pillar is made even if the stone mod already has a type_pillar (or if both furniture mod and stone mod add a type with the same name), but from your commits that looks intended.
I am seeing a lot less stone types getting detected (some that indeed did not seem like stone types, which yeah I wouldn't consider that an issue, but also some that did seem like stone types) than before though, but I'll go make a separate issue for that. (Probably tomorrow though)
Alright,
if you find some undetected stoneTypes. I'll need the ID of that stoneTypes, so i can manually add it.
you are correct, it was intended because there are too many stoneTypes from Chipped and Create that shouldn't be included
c/stone_mod/type_pillar is made even if the stone mod already has a type_pillar
Can i get the stone_mod, so i can take a look
EDIT:
On another note, The detection system are set to use a RegEx [a-z]+_bricks
that designed to find all of stoneTypes with just 2 words: <type>_bricks
, then "_bricks" can be separated to get the name of StoneTypes to find other children.
It's not perfect, tho. WoodTypes have similar issues in the past.
Try v2.7.2 and let me know if the issue is resolved. (it will take a while for the version to get approval on Curseforge)
EDIT: wrong issue. it resolved the missing textures