Every Compat (Stone Zone)

Every Compat (Stone Zone)

Mods
74 Downloads

[🐞]: Create stairs and slabs have each other's block states

VoidLeech opened this issue · 3 comments

commented

Code of Conduct

  • Always check you are using the latest version of the mods and its dependencies
  • Ensure the version of EveryCompat & Moonlight Lib are up to date
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version - Loader (DO NOT FORGET TO SELECT THE CORRECT VERSION)

1.20.1 - FORGE

EveryCompat Version

everycomp-1.20-2.7.3 (stonezone-1.20-2.7.0)

Moonlight Lib Version

moonlight-1.20-2.13.33

Issue with mods

Create 0.5.1j
Any stone mod (in the example: Deep Aether 1.0.4)

Issue Detail

Stairs have the slab block states
Slabs have the stair block states
This ALSO applies to the collision model.
They also have no model, but that's probably because the states are wrong.

OPTIONAL: Latest.log | Crash-report Attachment

2024-12-11_18 50 54
2024-12-11_18 50 29

OPTIONAL: To Produce

  1. /setblock ~ ~ ~ everycomp:/deep_aether/cut_aether_mud_slab
  2. /setblock ~ ~1 ~ everycomp:/deep_aether/cut_aether_mud_stairs
commented

StoneZone/common/src/main/java/net/mehvahdjukaar/stone_zone/modules/create/CreateModule.java

Lines 44 to 56 in 119a6bd

cut_andesite_stairs = SimpleEntrySet.builder(StoneType.class, "slab", "cut",
getModBlock("cut_andesite_slab"), () -> StoneTypeRegistry.ANDESITE_TYPE,
stoneType -> new StairBlock(stoneType.stone.defaultBlockState(), Utils.copyPropertySafe(stoneType.stone)))
//TEXTURES: Using cut_andesite's from above
.setTabKey(tab)
.setRenderType(RenderLayer.CUTOUT_MIPPED)
// .defaultRecipe()
.build();
this.addEntry(cut_andesite_stairs);
cut_andesite_slab = SimpleEntrySet.builder(StoneType.class, "stairs", "cut",
getModBlock("cut_andesite_stairs"), () -> StoneTypeRegistry.ANDESITE_TYPE,

Looks like the names in getModBlock are just mixed up here

commented

Thanks for the report and Gotcha.

commented

FIXED in v2.7.1