Every Compat (Stone Zone)

Every Compat (Stone Zone)

39.2k Downloads

[๐Ÿ—ƒ]: caverns and chasms' sugilite

Derpgamer22 opened this issue ยท 26 comments

commented

Code Of Conduct

  • See (LINK WILL BE ADDED IN FUTURE) if someone already suggested a mod that you are going to suggest.
    FOR NOW check out the issues
  • The mod MUST contain variant StoneType: STONE or other vanilla StoneTypes for ITEM or BLOCK

Curseforge (Normal)

https://www.curseforge.com/minecraft/mc-mods/caverns-and-chasms

Curseforge-Fabric (Optional)

No response

Version Loader Availability

  • 1.20.1 | FABRIC
  • 1.21.1 | FABRIC
  • 1.20.1 | FORGE
  • 1.21.1 | NEOFORGE

MODID

caverns_and_chasms

Types

this mod adds a new stone type: sugilite
maybe you could add it?

also there is another that isn't fully out yet and is in only in a beta on pateron as of this moment called cassiterite that does something similar to what wardstone did... so when this would get fully added, it would have to go to a similar process of what you did to wardstone with wizards blocks tag. Cassiterite would require the tags: caverns_and_chasms:deflects_projectiles & caverns_and_chasms:weaker_deflect_velocity

Optional Information

No response

commented

but yes that is the tag

commented

I think it be better if I show you tbh

commented

Also, since it got updated and now works with the various stone types, A possible addition to sugilite is adding the tag #caverns_and_chasms:static_note_blocks to it so they can make that new sound for some sort of compat. Also, the cassiterite blocks seemed to get added too after your cool thing you did so maybe you could add the tags, I mention above for cassiterite. It's whatever you decide on, just be a nice compat for them. Also, I wanted to mention one more thing... Whatever you did for this new update allows stone blocks made from KUBEJS to WORK. I made my OWN STONE with this, and I saw it in the generation list, and I just wanted to say that that is amazing. :P

Tags for cassiterite blocks:
#caverns_and_chasms:deflects_projectiles
#caverns_and_chasms:weaker_deflect_velocity

Tag for Sugilite blocks:
#caverns_and_chasms:static_note_blocks

commented

I need the id of sugilite

does it have polished block or bricks block, if it don't have any. then yeah i can manually add it.

also there is another that isn't fully out yet and is in only in a beta on pateron as of this moment called cassiterite that does something similar to what wardstone did... so when this would get fully added, it would have to go to a similar process of what you did to wardstone with wizards blocks tag. Cassiterite would require the tags: caverns_and_chasms:deflects_projectiles & caverns_and_chasms:weaker_deflect_velocity

yeah i can add that.


EDIT:

FYI, you could use "Undetected StoneType" issue instead of "Suggest A mod"

commented

๐Ÿ‘๐Ÿป alright, StoneZone only detect 2 words, TYPE_bricks or polished_TYPE but not 3 words.. it has to be manually added.

Will add them and let u know when it's done.

commented

my bad and yes it does have a polished type

caverns_and_chasms:sugilite for the normal one

caverns_and_chasms:polished_sugilite for polished

there is no bricks for it

commented

there is also some other stone types I would like to suggest

commented

atmospheric has some stone blocks:
Dolerite
atmospheric:dolerite

Travertine

atmospheric:ivory_travertine
atmospheric:peach_travertine
atmospheric:persimmon_travertine
atmospheric:saffron_travertine

commented

dolerite has a polished block and the travertine kinda do.. but they are called cut instead so like atmospheric:cut_ivory_travertine for example

commented

there is also gypsum from arts and crafts

arts_and_crafts:gypsum

commented

Ok it turned out caverns_and_chasms:polished_sugilite has HARP sound. so it's added. and for other, i'll check.

StoneZone also check for these blocks with BASE_DRUM. that's how these stoneType are detected.


Others are added.

commented

ADDED in v2.7.12


Improved the detection system to detect stoneType with HARP sound

related to StoneTypeRegistry: Improved detection by adding HARP sound & Fix #42

Manually ADDED in v2.7.13

commented

A stone type should not have harp noteblock type. Of it does it's a bug wouldn't you agree?
Also nobody is talking about the block sound

commented

that is true, my bad

commented

OOH WAIT!! So sugilite actually makes a different note block sound!

commented

Their is a special one for it for spinel related stuff
idk if it is only for the pateron version though

commented

yea that's why it should be reported to DEV. what are the chance that DEV will fix the bug. There are too many mods that have StoneType with HARP sound. I had to improve the system detection for that.

it check for 2 things: the naming scheme (_bricks or polished_) and sound (HARP or BASE_DRUM)

commented

wait are you saying that sugilite makes the harp sounds?

commented

Oh, so it their pateron version, it has a new custom noteblock sound

commented

so they would not change it to be the base

commented

it does. I checked.

commented

that's exactly why i had to include HARP sound to the detection system. I figured that DEV would be so stubborn to not change the sound of a StoneType.

commented

but it isn;y the fact that they didn't change it to be the stone sound for note blocks, it the fact that they are giving it it's own special new sound that they add call Static... tbh I'd say talk to them about it

commented

I ment Bass*

commented

๐Ÿ˜ญ

commented

huh? you gotta kidding me. "static" something sound. that's not good. it's caverns_and_chasms:sugilite right?