Storage Drawers: Biomes O' Plenty Pack

Storage Drawers: Biomes O' Plenty Pack

6M Downloads

Player name changed, storage drawers not working now...

therealericbj opened this issue ยท 12 comments

commented

I have a little server that myself and a few friends play on.

One player was using StorageDrawers quite extensively, then changed his player name.

Now he is able to craft the drawers, place the drawers and add items to the drawers, but he is unable to take anything out of the drawers.

Other players have tried placing the drawers for him and it makes not difference.

Server is Minecraft 1.7.10, with Forge 1291 and this problem exists for versions 1.2.0 and 1.2.3 of your mod.

Can you help us? What did we mess up?

Thanks.

commented

The UUID stuff is only related to inserting objects. So that's not relevent.

Only thing I can think of is stuff is extracted with left-click, which needs to send a separate packet to the server. Maybe that association is somehow bungled for him, and the only thing I can suggest is that both he and the server restart and see if it's still a problem.

commented

I've added a small amount of logging to the new release (1.2.4), which can be enabled in the config. Do so for both client and server. It will report a little extra information in the logs when interacting with the drawer. I'm exploring a very specific area: whether or not the server is handling this particular player's left click actions.

commented

Can you try restarting the server? I think it cached his UUID (for supporting the double-click behavior), and a restart might clear that.

I'll double-check the caching code.

commented

Thank you for the quick reply.

Server and client has been restarted, some several times, and the mod upgraded a couple of times since the problem was discovered.

So we should upgrade server and client with version 1.2.4 and pay close attention to the consoles when he tries to use the drawers, okay.

Should these tests be performed with newly made drawers, the existing drawers or does it matter?

I'll let you know what the logs say.

Thanks.

commented

Doesn't matter. But make sure you turn the options on, because they are off by default. Take the log from the server after he's tried extracting items a few times, and make sure he takes his client log too.

Remember that he can get his stuff out in the interim with hoppers/pipes/AE2 system

commented

This is what the server log said when he right-clicked and shift-right-clicked something into the drawers...
[12:17:35] [Server thread/INFO] [StorageDrawers/]: BlockDrawers.onBlockActivated
[12:17:35] [Server thread/INFO] [StorageDrawers/]: 3xitem.egg@0
This is what the server log said when he left-clicked and shift-left-clicked to take something out...
[12:18:24] [Server thread/INFO] [StorageDrawers/]: BlockDrawers.onBlockActivated
[12:18:24] [Server thread/INFO] [StorageDrawers/]: null item
[12:18:24] [Server thread/INFO] [StorageDrawers/]: BlockDrawers.onBlockActivated
[12:18:24] [Server thread/INFO] [StorageDrawers/]: null item
[12:18:24] [Server thread/INFO] [StorageDrawers/]: BlockDrawers.onBlockActivated
[12:18:24] [Server thread/INFO] [StorageDrawers/]: null item
[12:18:24] [Server thread/INFO] [StorageDrawers/]: BlockDrawers.onBlockActivated
[12:18:24] [Server thread/INFO] [StorageDrawers/]: null item

He says this is what his client console window showed him when did the same...

                                         BlockDrawers.onBlockActivated

[09:21:32] [Client thread/INFO] [StorageDrawers]: 3xitem.confusingDust@0
[09:21:50] [Client thread/INFO] [StorageDrawers]: BlockDrawers.onBlockActivated
[09:21:50] [Client thread/INFO] [StorageDrawers]: null item

I hope this helps you out.

Let me know if you need anymore information...

Thanks.

commented

It should not be calling onBlockActivated. That's what gets called for right-click. If he left-clicks an empty slot with something in his inventory, does that also insert the contents into the drawer?

What you should be seeing is a message for onBlockClicked. You should hopefully be able to confirm that in your own client.

If you also have JABBA installed, I'd like to know if he has problems with those barrels too.

commented

I placed a large 2 slot storage drawer. I right-clicked 16 bones into the first slot.

Server log says this...
[03:12:20] [Server thread/INFO] [StorageDrawers]: BlockDrawers.onBlockActivated
[03:12:20] [Server thread/INFO] [StorageDrawers]: 16xitem.bone@0

Client logs say this...
[02:11:53] [Client thread/INFO] [StorageDrawers]: BlockDrawers.onBlockActivated
[02:11:53] [Client thread/INFO] [StorageDrawers]: 16xitem.bone@0

I left-clicked the first storage drawer slot to remove an item.

The server log said this...
[03:16:52] [Server thread/INFO] [StorageDrawers]: IExtendedBlockClickHandler.onBlockClicked
[03:16:52] [Server thread/INFO] [StorageDrawers]: 1xitem.bone@0

The client log says this...
[02:15:10] [Client thread/INFO] [StorageDrawers]: BlockDrawers.onBlockClicked with HitResult{type=BLOCK, x=3195, y=224, z=434, f=4, pos=(3195.0, 224.75222437511886, 434.58480417977796), entity=null}

I shift-left-clicked to remove items.

The server said this...
[03:21:30] [Server thread/INFO] [StorageDrawers]: IExtendedBlockClickHandler.onBlockClicked
[03:21:30] [Server thread/INFO] [StorageDrawers]: 48xitem.bone@0

The client said this...
[02:21:42] [Client thread/INFO] [StorageDrawers]: BlockDrawers.onBlockActivated
[02:21:42] [Client thread/INFO] [StorageDrawers]: 48xitem.bone@0
[02:21:46] [Client thread/INFO] [StorageDrawers]: BlockDrawers.onBlockClicked with HitResult{type=BLOCK, x=3195, y=224, z=434, f=4, pos=(3195.0, 224.79704137220511, 434.53208029922945), entity=null}

I left-clicked on an empty slot with something in my hand. Nothing was placed in the slot.

The server log said this...
[03:24:43] [Server thread/INFO] [StorageDrawers]: IExtendedBlockClickHandler.onBlockClicked
[03:24:43] [Server thread/INFO] [StorageDrawers]: null item

The client log said this...
[02:23:02] [Client thread/INFO] [StorageDrawers]: BlockDrawers.onBlockClicked with HitResult{type=BLOCK, x=3195, y=224, z=434, f=4, pos=(3195.0, 224.84160990791622, 434.57843744294155), entity=null}

I'll go through the experiment again with him tomorrow to be certain of the results.

Incase it makes a difference, we are also using Refined Relocation which modifies the Jabba barrel to become a Sorting Barrel.

commented

Yeah, your client is behaving completely normal, and that's the logging that you want to see happen when he works with the drawers. I don't know if refined relocation will make a difference on JABBA, but it's the only block I could think of offhand where the left-click behavior doesn't just duplicate the onBlockActivated action. And I feel like his client just isn't handling that distinction correctly.

Have you tried zipping up your client instance (minus the large Saves directory) and having him try using that? Maybe he has an extra client mod throwing things off?

commented

Hi, did you ever resolve this?

I have seen two other instances of this problem since the last comment here. In both cases, the affected player was set to Adventure Mode. Getting out of Adventure Mode resolved the issue.

commented

You hit the nail on the head. The player didn't realize that he was in Adventure mode. He switched back to Survival mode and everything worked perfectly after that.

Thank you for helping me sort out this issue.

commented

Great, thanks for confirming.