Storage Drawers: Biomes O' Plenty Pack

Storage Drawers: Biomes O' Plenty Pack

6M Downloads

Virtual slots ratio of currently stored items/total possible storable items space

Ghent opened this issue ยท 1 comments

commented

Hello,

Using mods that look in the drawers to see if they're full, empty, or a quantity always show as having an extremely small amount of max value in storage.

To reproduce, I am using buildcraft 7.99.15 gates and it is checking a basic drawer to see if it's 75% full. The drawer always shows as almost empty, as my mod thinks that is only has 0.00000095367431640625 of maximum items count.

Software Version
Minecraft: 1.12.2
Forge: 1.12.2-14.23.2.2618
Buildcraft: 7.99.16-pre1
Buildcraft-compat: 7.99.14
Storage Drawers: 1.12.2-5.3.4

This seems to be related to the following lines:
https://github.com/jaquadro/StorageDrawers/blob/1.12/src/com/jaquadro/minecraft/storagedrawers/capabilities/DrawerItemHandler.java#L137-L138

commented

Hard to decide what the best behavior is on this case. I wonder if this (virtual) slot were to return 0, then some mods would avoid trying to insert into it, which would effectively disable a bunch of features of the block.