Storage Drawers: Biomes O' Plenty Pack

There's an issue I've been having with the Auto-convert item, because as I place a different type of ingot and then another in a compacting drawer with the auto-convert upgrade, it doesn't auto convert the other to the other. I was searching this issue myself and got myself nowhere, I also checked the config file and didn't see anything about manually doing the auto-convert code myself, so yeah I'm really at a lost here.

The version is 1.16.4 and the drawer mod is the most updated ;-; halp

Same issue as above with Tinker's, Thermal, and Mekanism installed, which add some of the same metals. Most notably copper, lead, tin, and bronze.

Minecraft 1.16.5
Forge 36.2.2
Storage Drawers 8.3.0
Tinker's Construct 3.1.1.252
Thermal Foundation 1.3.2
Mekanism 10.0.21.448

The conversion upgrade is being checked for...

StorageDrawers/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/UpgradeData.java

Lines 180 to 199 in 99c733e

    
           for (ItemStack stack : upgrades) { 
        
               Item item = stack.getItem(); 
        
               if (item == ModItems.ONE_STACK_UPGRADE) 
        
                   hasOneStack = true; 
        
               else if (item == ModItems.VOID_UPGRADE) 
        
                   hasVoid = true; 
        
               else if (item == ModItems.CONVERSION_UPGRADE) 
        
                   hasConversion = true; 
        
               else if (item == ModItems.CREATIVE_STORAGE_UPGRADE) 
        
                   hasUnlimited = true; 
        
               else if (item == ModItems.CREATIVE_VENDING_UPGRADE) 
        
                   hasVending = true; 
        
               else if (item == ModItems.ILLUMINATION_UPGRADE) 
        
                   hasIllumination = true; 
        
           } 
        
           attrs.setIsVoid(hasVoid); 
        
           attrs.setIsDictConvertible(hasConversion); 
        
           attrs.setIsUnlimitedStorage(hasUnlimited); 
        
           attrs.setIsUnlimitedVending(hasVending);

StorageDrawers/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/UpgradeData.java

Lines 148 to 150 in 99c733e

    
           public boolean hasConversionUpgrade () { 
        
               return hasConversion; 
        
           }

StorageDrawers/src/main/java/com/jaquadro/minecraft/storagedrawers/capabilities/BasicDrawerAttributes.java

Lines 120 to 133 in 99c733e

    
           @Override 
        
           public boolean isDictConvertible () { 
        
               return isConversion; 
        
           } 
        
           @Override 
        
           public boolean setIsDictConvertible (boolean state) { 
        
               if (isConversion != state) { 
        
                   isConversion = state; 
        
                   onAttributeChanged(); 
        
               } 
        
               return true; 
        
           }

...but this isn't actually doing anything in practice.

StorageDrawers/src/main/java/com/jaquadro/minecraft/storagedrawers/util/ItemStackOreMatcher.java

Lines 1 to 12 in 99c733e

    
           /*package com.jaquadro.minecraft.storagedrawers.util; 
        
           import com.jaquadro.minecraft.storagedrawers.StorageDrawers; 
        
           import net.minecraft.item.ItemStack; 
        
           import net.minecraftforge.oredict.OreDictionary; 
        
           import javax.annotation.Nonnull; 
        
           import java.util.ArrayList; 
        
           import java.util.List; 
        
           public class ItemStackOreMatcher extends ItemStackMatcher 
        
           {

StorageDrawers/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/StandardDrawerGroup.java

Lines 200 to 203 in 99c733e

    
           //if (attrs.isDictConvertible()) 
        
           //    matcher = new ItemStackOreMatcher(protoStack); 
        
           //else 
        
               matcher = new ItemStackMatcher(protoStack);

StorageDrawers/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/FractionalDrawerGroup.java

Lines 414 to 425 in 99c733e

    
           private void populateSlots (@Nonnull ItemStack itemPrototype) { 
        
               World world = group.getWorld(); 
        
               if (world == null) { 
        
                   protoStack[0] = itemPrototype; 
        
                   convRate[0] = 1; 
        
                   matchers[0] = new ItemStackMatcher(protoStack[0]); 
        
                   //matchers[0] = attrs.isDictConvertible() 
        
                   //    ? new ItemStackOreMatcher(protoStack[0]) 
        
                   //    : new ItemStackMatcher(protoStack[0]); 
        
                   return; 
        
               }

StorageDrawers/src/main/java/com/jaquadro/minecraft/storagedrawers/block/tile/tiledata/FractionalDrawerGroup.java

Lines 471 to 478 in 99c733e

    
           private void populateRawSlot (int slot, @Nonnull ItemStack itemPrototype, int rate) { 
        
               protoStack[slot] = itemPrototype; 
        
               convRate[slot] = rate; 
        
               matchers[slot] = new ItemStackMatcher(protoStack[slot]); 
        
               //matchers[slot] = attrs.isDictConvertible() 
        
               //    ? new ItemStackOreMatcher(protoStack[slot]) 
        
               //    : new ItemStackMatcher(protoStack[slot]); 
        
           }

Functionality for this upgrade is disabled, and apparently has been for a long time.

It's been the better part of a year and nothing has happened on this issue at all.

It's been the better part of a year and nothing has happened on this issue at all.

oof... I gave up on the upgrade and just went for alternatives, but damn this would be fucking useful ;-;

up

@jaquadro

@jaquadro you should probably either fix this or disable the conversion upgrade completely. In it's current state it's very misleading.

Include the conversion upgrade in the compacting drawers recipe or remove it please, I litteraly googled for 20mins what this upgrade does

bump

also bump

bump

Bump

A year and a half of nothing from the mod author isn't very encouraging.

this is a dumb issue, shouldnt be one and is a really easy fix. just remove it and stop misleading people

I'm also having this issue and I would love to have it fixed, I have no way I know of to ore-dictionary convert items.

Playing the Direwolf20 1.16 pack and ran into this issue myself. Tetra Geodes currently gives different versions of different nuggets. The only way I've found to resolve this is to manually craft them into ingots as I also tried the conversion upgrade and found it didn't work. The ingot recipe works, but the conversion upgrade does not. Compacting drawers were useful for this.

Same issue. Conversion upgrade is in place but mekanism and tinkers copper are not converting.

	for (ItemStack stack : upgrades) {
	Item item = stack.getItem();
	if (item == ModItems.ONE_STACK_UPGRADE)
	hasOneStack = true;
	else if (item == ModItems.VOID_UPGRADE)
	hasVoid = true;
	else if (item == ModItems.CONVERSION_UPGRADE)
	hasConversion = true;
	else if (item == ModItems.CREATIVE_STORAGE_UPGRADE)
	hasUnlimited = true;
	else if (item == ModItems.CREATIVE_VENDING_UPGRADE)
	hasVending = true;
	else if (item == ModItems.ILLUMINATION_UPGRADE)
	hasIllumination = true;
	}

	attrs.setIsVoid(hasVoid);
	attrs.setIsDictConvertible(hasConversion);
	attrs.setIsUnlimitedStorage(hasUnlimited);
	attrs.setIsUnlimitedVending(hasVending);

	public boolean hasConversionUpgrade () {
	return hasConversion;
	}

	@Override
	public boolean isDictConvertible () {
	return isConversion;
	}

	@Override
	public boolean setIsDictConvertible (boolean state) {
	if (isConversion != state) {
	isConversion = state;
	onAttributeChanged();
	}

	return true;
	}

	/*package com.jaquadro.minecraft.storagedrawers.util;

	import com.jaquadro.minecraft.storagedrawers.StorageDrawers;
	import net.minecraft.item.ItemStack;
	import net.minecraftforge.oredict.OreDictionary;

	import javax.annotation.Nonnull;
	import java.util.ArrayList;
	import java.util.List;

	public class ItemStackOreMatcher extends ItemStackMatcher
	{

	//if (attrs.isDictConvertible())
	// matcher = new ItemStackOreMatcher(protoStack);
	//else
	matcher = new ItemStackMatcher(protoStack);

	private void populateSlots (@Nonnull ItemStack itemPrototype) {
	World world = group.getWorld();
	if (world == null) {
	protoStack[0] = itemPrototype;
	convRate[0] = 1;
	matchers[0] = new ItemStackMatcher(protoStack[0]);
	//matchers[0] = attrs.isDictConvertible()
	// ? new ItemStackOreMatcher(protoStack[0])
	// : new ItemStackMatcher(protoStack[0]);

	return;
	}

	private void populateRawSlot (int slot, @Nonnull ItemStack itemPrototype, int rate) {
	protoStack[slot] = itemPrototype;
	convRate[slot] = rate;
	matchers[slot] = new ItemStackMatcher(protoStack[slot]);
	//matchers[slot] = attrs.isDictConvertible()
	// ? new ItemStackOreMatcher(protoStack[slot])
	// : new ItemStackMatcher(protoStack[slot]);
	}

Share to