Storage Drawers should be water-loggable for underwater awesomeness
jsuereth opened this issue ยท 1 comments
Would be awesome if storage drawers could be waterlogged to allow underwater storage centers in 1.15+.
I have a patch to 1.15 that appears to make this work, but has some clipping issues in various viewing angles. Wanted to first check with you on whether or not you'd be amenable to such a patch before spending more time on it.
Screenshots:
Non-waterlogged storage drawer
Waterlogged storage drawer (uses my patch):
The current rendering issue I'd need to look into
TL;DR: on the work I've discovered (for 1.15 branch):
- Register
BlockStateProperties.WATERLOGGED
as a property of storage drawers - Implement
IWaterLoggable
- Override
getFluidState
to return still water state if waterlogged. - Override
getStateForPlacement
to check if placing into a block with FluidState of an appropriate water level, if so auto-waterlog the block.
Not sure where to look for the rendering issue that clips the front, but I can try to chase that down.