Storage Drawers

Storage Drawers

151M Downloads

[Botania] Mana Tablets

EchoingZen opened this issue ยท 10 comments

commented

Placing Mana Tablets in a Storage Drawer appears to strip the bar from the tablet. A possible explanation was given by lazersmoke on reddit.

"The problem is that the storage drawer makes the mana tablet lose its damage value, which makes it think it is creative (thus no mana bar), but its actually still a normal mana tablet. I would file a bug report here. and tell them they aren't preserving the damage values of mana tablets."

Some of my tablets have this, some do not. It may be related to logging out when they are in a drawer.

(Regrowth modpack, FYI)

commented

I just reproduced it.

Step one: Fill a tablet to full.
Step two: put the full tablet (with damage bar) into a storage drawer.
Step three: quit Minecraft
step four: open Minecraft
Step five: pull out the tablet with no bar.

commented

When if you don't quite fill it?
And what happens when you try using the tablet after you remove it?

commented

If you don't quite fill it.. its fine. I can take them out after relogging and everything appears normal. I believe it only affects full tablets. I haven't tested empty tablets.

commented

I just reproduced it.

Did the same thing and reproduced it here. I just did some testing with MCEdit:

A full mana tablet (500k mana) normally has Damage=1.

After doing the steps you gave, the full mana tablet (missing a damage bar) pulled from the drawer has Damage=0.

commented

So, the drawer indeed writes out a 0 damage value on NBT save. But the prototype stack stored within the drawer itself has the correct damage value of 1.

Vakii has an inconsistency in the mana tablet implementation. The item overrides the getDamage() accessor, and scales the internal mana value (range 0 - 500,000) to a damage value in the range (0 - 1000). If the mana is completely full, it calculates an inconsistent damage value of 0. This needs to be brought up there.

commented

That would explain why the HQM quest rewards seem to have the same problem!

commented

I'll make a report to Vazkii then :)

commented

Drawers should always be preserving damage values. But maybe there's something special with tablets. I'll need to look.

commented

I'm playing the regrowth pack right now, so I gave it a try.

Cannot confirm, mana tablets keep their damage bars after going into and out of a drawer.

However, I remember that in the early botania quests that give mana tablets as a reward, those tablets do not have damage bars. The damage bars appeared on them some time later, but I'm not sure when. Maybe when I relogged?

commented

A solution to this problem was merged a little while ago, and just involved removing damage values entirely in favor of using other methods for showing the durability bar. I tested with storage drawers after the patch and it seems to be in order now.