Storage Drawers

Storage Drawers

Mods
151M Downloads

Drawer Controllers/Slaves Ignore Void Upgrades on Compacting Drawers

nrllewellyn opened this issue ยท 4 comments

commented

Expected behavior:
Inserting items into a drawer that has a void upgrade via a drawer controller should always succeed.

Steps to reproduce:

  1. Place a compacting drawer with a void upgrade (I also used a storage downgrade to speed testing)
  2. Fill the drawer
  3. Attach a Drawer Controller
  4. Attempt to insert items
  5. Items will not be inserted

Tested versions:
Forge: 1.12.1-14.22.0.2474
Storage Drawers: 5.3.2

commented

Tests (all drawers are full w/ void upgrade and storage downgrade):

  • Compacting drawer (iron ingot/block), insert iron block: Fails
  • Compacting drawer (iron ingot/block) + basic drawer (iron block), insert iron block: Succeeds
  • Compacting drawer (iron ingot/block) + basic drawer (iron block), insert iron ingot: Fails
  • Compacting drawer (iron ingot/block) + basic drawer (iron ingot), insert iron ingot: Succeeds

So the issue appears to be 100% isolated to compacting drawers.

commented

Does this only happen with the Compacting Drawer and not any others?

commented

The void check is happening too late in the item adjustment method for compacting drawers.

commented

Fixed in 5.3.3