Storage Drawers

Storage Drawers

151M Downloads

[1.16.2] Drawers not remembering locked items when the item ran out and the chunk was reloaded

SeraphJACK opened this issue ยท 6 comments

commented

Synopsis

Drawers not remembering locked items when the item ran out and the chunk was reloaded. When I put some items in the drawers and locked it, and pull out all the items, then teleport to a faraway place (outside of current view distance) and teleport back, the item disappears.

How to reproduce

  1. Put a drawer in the ground
  2. Store something in the drawer
  3. Lock the drawer with the drawer key
  4. Teleport to a faraway place where the drawer is outside of the player's view distance
  5. Teleport back

Environment

  • MinecraftForge 33.0.61
  • StorageDrawers 1.16.2-8.1.0

Screenshots

}(LZND}FOS_$NOJNH7E6T
PYPY6~Z41AK0OWCAK O(CA6
K@ F}E6B1MRONE1S45BRQXI
TK4MO6 PMDB39R(K{ 1T7X

commented

Maybe forgot to serialize it?

commented

Unfortunately, this has been with us for a long time (see #704, #800, #810, #833, #863, #877). Not auspicious, I think.

commented

It's really just cherry picking one specific commit from 1.14 branch and nothing more. I get this to work in 1.16 by simply doing git cherry-pick 52a0e0a4ed2aa33fabb02acb05edce9c42618559 and there is even no merge conflicts.

commented

I am having the same issue, I have Botany pots on 2x2 drawers, locked, if the last of an item is removed the drawer will show the item as normal but it will lose memory of what is stored at some point. This stops the botany pot from working as the draw is locked to other items or empty slots. If I have the draws unlocked the items I am leaving in it will fill all the slots and it will stop the botany pot from working.
Edit. It is not only when the chunks reload. I have also have the remembered items disappear by shift clicking to enter the UI. Placeholder textures are there on the front before entering but the UI only show places that have contents and exiting shows the contents but the placeholders are missing

commented

I am experiencing the same issue. I noticed it on quitting and restarting the game (single player), but it also happens when moving a long distance away or when opening the drawer's GUI. Happens with vanilla and modded items (I noticed it first on my Coal / Coal Coke drawer). I was able to reproduce it with all drawer types and all items I tried. It doesn't seem to matter whether the Game Mode is creative or survival, whether the Quantity Key has been used on the drawer, or whether the drawer has any upgrades.

Minecraft version: 1.16.3 (latest)
StorageDrawers version: 1.16.2-8.1.0 (latest)
Other mods of note: Immersive Engineering, Client Tweaks, Inventory Tweaks (reloaded), Iron Chests, Optifine

commented

I'm getting this bug as well. I'm on All The Mods 6 (too many mods to list) with Minecraft 1.16.3 and Storage Drawers 1.16.2-8.1.0.