Straw Golem Rebaled

Straw Golem Rebaled

5M Downloads

[1.19-Forge] Java Heap Space crash after awhile.

Gbergz opened this issue ยท 18 comments

commented

Game Info
Game Version : 1.19
Mod Version : 2.0.0b1
Mod Loader : Forge

Describe the bug
After awhile, server lags and server crashes due to Java Heap Space.

To Reproduce
Not sure really how to, just have the server on, use some golems.
Profit.

Screenshots
No response.

Additional context
Crash report: https://gist.github.com/Gbergz/f434f23f838de384d6b065cff5923f7d

Edit : Maybe a cross issue with croptopia?

commented

Keep getting the out of memory crashes, still.
Haven't tried the build above where Ayrie. But will do whenever I got time. Will that fix it? That needs to be on CurseForge if so.

commented

The old croptopia issue with saplings has been fixed, this appears to be something else most likely.

Out of curiosity, once the server crashes the first time, does it crash much sooner on subsequent launches?

I'm trying to see if the root of this is a bug with the OctTrees leaking memory somehow, or if its actually them just taking up too much space.

commented

Out of curiosity, once the server crashes the first time, does it crash much sooner on subsequent launches?

I'm not quite sure actually. Maybe.

commented

Try using the forge artifact from this run:

https://github.com/t2pellet/strawgolem/actions/runs/2532809336

(open the zip file and use the regular jar, not the dev or sources ones)

Let me know if that fixes the issue for ya?

commented

Will try that when I get the chance! Thanks

commented

@Gbergz let me know if this is resolved with the build I sent!

commented

Thing is the crash is no longer happening so I can't really figure out if the build fixed it or not. Haven't tried it yet though, haven't had time.

commented

Yeah, that. And if I edit the config below.

#Golem lifespan in ticks. Set to -1 for infinite
lifespan = 168000 to 1

Setting it to 1 solves it, server no longer dies.

commented

Okay it's happening again, gonna try using that build now.

commented

That seems odd, setting it to 1 will just make golems die in 1 tick.

The issue from your latest crashlog is related to world saving, which isn't impacted by golems existing or not.

This run should have an artifact with a potential fix when its done, give it a try?:
https://github.com/t2pellet/strawgolem/actions/runs/2577483121

commented

Still happens on that version.
Server went on to hang for 720s (which is the server watchdog timer).

Happens after this in console:
[Server] [Server thread/INFO] [strawgolem/]: Saving strawgolem save data

Crash-log:
https://gist.github.com/Gbergz/19d268633a19e24decec3d07a41867c2

commented

And if you remove strawgolem entirely the problem goes away?

commented

@Gbergz that does look like a separate issue, weird one too, looks like it was getting a null somewhere comparing candidate nearest crops.

Not quite sure why that would happen, but the build below should protect against that, or at least provide better logging
https://github.com/t2pellet/strawgolem/actions/runs/2578485081

commented

@Aiyrie this build (when completed) should fix that issue:
https://github.com/t2pellet/strawgolem/actions/runs/2578542473

commented

Sweet, can't test it right now. But will it be on CurseForge?

commented

So far, so good with that build. Been testing for a bit now.

commented

Nevermind exactly when I posted that, the server crashed hard.
might just be a new issue entirely
https://gist.github.com/Gbergz/6b487386794b70b36d74af06f69893d2

commented

Should be fixed in 2.0.0.beta-3