[Question] BlockEntity Based Crops
InfinityRaider opened this issue · 10 comments
Hello,
I have been following the development of your mod from a distance, as I wanted to implement compat with my mod as well (I had made a PR for this a while ago).
In the meantime, I have noticed you have implemented support for BlockEntity based crops, the entry point for which, I believe, happens here?
Although it is a good thing that you were mindful of BlockEntity based crops, it is a bit of a problem that it still requires a Block property for the age of the crops, which is not guaranteed for BlockEntity based crops (in fact, mine don't, as it would be redundant, and basically impossible as well).
Therefore, my question is, are you planning to expand upon this?
And if not, would you mind if I drafted up a PR instead?
Thanks for taking the time and effort to look into this.
This is indeed a big step forward.
As a followup question, is there a way to tell the golem they should right click the crop instead of breaking it?
Hello again,
Would it be possible to push out a build on CurseForge containing these commits?
I am asking, as I am using cursemaven to add the build to my dev environment, and the current version on CurseForge does not have these changes it seems?
Unless you are hosting a maven repo somewhere I could grab the artefacts from instead?
Actually, some changes might be necessary, I think it would be better to register a BlockEntityType instead of a BlockEntity, as the type is a registered constant, the BlockEntities themselves are volatile objects.
Using them like this risks causing memory leaks
Hey! Should have build up on CurseForge with the changes by EOW. I don't have my own maven repo set up, at least not yet :)
Thanks, no worries.
Could I get a poke when you put out a build with these changes? Thanks!
@InfinityRaider Build has been uploaded and is under review!
Compat implemented: AgriCraft/AgriCraft@b8c10a9
Thanks for the cooperation!