OpenTerrainGenerator 1.12.2 v9_r10 doesn't work with Streams
PG85 opened this issue · 10 comments
For the latest dev versions of OTG 1.12.2 v9, Streams doesn't work anymore. Some classes were moved (com.pg85.otg.forge.ForgeWorld -> com.pg85.otg.forge.world.ForgeWorld), I created a workaround so Streams' old implementation should still work, that fixed any crashes/exceptions but Streams still only worked for vanilla worlds. I didn't see any more exceptions, so I'm not sure what broke Streams. Will need some help with this, could you try building with the latest dev version of OTG and see if that shows any problems? Jar is attached (rename .zip to .jar), code is here: https://github.com/PG85/OpenTerrainGenerator/tree/1.12-v9) .
*I've not included the fixes/workaround for the ForgeWorld refactor, so you'll get build errors. OTG v9 should be released within a few weeks, so if you could do an update some time after that, that would be ideal. Big thanks and cheers.
Hi @PG85, this should be fixed in the new Farseek 2.5.1. Could you give it a try and let me know if it works? Thanks!
Looking good, big thanks :)
*There do appear to be some lines going across the streams, not sure if that's intentional? Looks like it happens every time there's an elevation change in the water.
Glad to hear it's working. Yeah those solid lines are an old bug I've been unable to fix so far, they're normally quite rare though. Do they happen for every elevation change in all streams for the new OTG? Are other mods present in your test?
In any case I'll take another look this week and see if I have more luck finding the cause.
They do seem to appear quite consistently, I'm seeing them often. It looks like it's only happening when the elevation change actually switches to the next layer of blocks above/below. So it looks like just one "transition block" at the end that's missing. Thanks and cheers.
*Only have some minor QOL mods btw:
Sorry if this is off-topic, but which version of OTG does Streams work with? I went back to v8.3 and I'm still getting the transition blocks.
I just want to increase terrain height to get more Streams, this mod is gorgeous.
@PG85 @DieselpunkCyborg The new Streams 0.4.9 should fix the stone "bridges" over streams, could you give it a try?
