Structured Crafting

Structured Crafting

2M Downloads

doesn't work properly with the recipe `supplementaries:item_lore_display`

Closed this issue 17 comments

commented

Issue type:

  • 馃悰 Bug

Short description:

the structured crafter eats the nametag

tested with vanilla chests and PolyDecorations display cases as the input holder

Steps to reproduce the problem:

  1. have supplementaries installed
  2. try to add item lore by crafting a renamed nametag with another item
  3. see the nametag gets eaten

Expected behaviour:

the nametag wouldn't get eaten
it doesn't get eaten by crafting tables or vanilla crafters


Versions:

  • This mod: 0.2.7
  • Minecraft: 1.21.1
  • Mod loader version: Fabric 0.16.10
  • Supplementaries: 1.21-3.1.7

Log file:

commented

Thanks for reporting!

commented

What kind of recipe is this exactly?
Can you reproduce this with vanilla recipes?

commented

I've looked at it some more
supplementaries:item_lore_display is actually just what shows in recipe veiwers
the actual recipe is supplementaries:item_lore

some links that are hopefully helpful
https://github.com/MehVahdJukaar/Supplementaries/blob/b50b4c18f3ac4845eb36323813ee983142fdcc3d/common/src/main/java/net/mehvahdjukaar/supplementaries/common/items/crafting/SpecialRecipeDisplays.java#L199

https://github.com/MehVahdJukaar/Supplementaries/blob/1.21/common/src/main/java/net/mehvahdjukaar/supplementaries/common/items/crafting/ItemLoreRecipe.java

https://github.com/MehVahdJukaar/Supplementaries/blob/1.21/common/src/main/resources/data/supplementaries/recipe/item_lore.json

the vanilla cake recipe works and leaves the buckets in the inputs
although it doesn't work if an empty bucket is before a milk bucket in an input chest

GitHub
Contribute to MehVahdJukaar/Supplementaries development by creating an account on GitHub.
GitHub
Contribute to MehVahdJukaar/Supplementaries development by creating an account on GitHub.
GitHub
Contribute to MehVahdJukaar/Supplementaries development by creating an account on GitHub.
commented

I'm on this mod: 0.2.9 now

it still seems to be broken
also the vanilla banner copying recipe has I think the same issue (didn't test in earlier versions)

commented

How are you crafting the recipe exactly? Because it works fine on my end.

commented

crafter horizontal with chests at both ends

some chance it could be a mod incompat

commented

Could you share a screenshot or video?

commented

the chest under the glass has renamed nametags and the middle top chest has acacia planks
Image

commented

I tested removing lychee and polymer and they didn't seem to change anything
also updated fabric loader to 0.16.14

commented

Thanks for the additional information. I managed to reproduce your problem. Fix will be out soon!

commented

good news: some input arrangements work
bad news: some input arrangements crash the server world brickingly

commented

new issue, or continue this one?

commented

Could you attach the new crashlog please?

commented

this mod: 0.2.10
slime ball in top, renamed nametag in bottom
Image

crash-2025-05-12_01.04.21-server.txt

commented

Thanks! that is certainly helpful. Looks like an array mixup at first glance. I can't tell if this is related yet.

commented

Aha, that's a test case I didn't consider indeed. Thanks!

commented

I didn't test all 432 possible configurations, but all the ones I did test (only in a facing: south crafter) worked

thank you