UI Issues for Villagers and Hut Blocks - Requests and Material Lists
RuneVanguard opened this issue · 92 comments
Minecolonies version
Version: minecolonies-0.10.483-BETA-universal MC 1.14.4
Expected behavior
- UI Shows list of required materials when looking for requests in a villagers UI or building material lists in a Hut Block UI
Actual behaviour
- UI isn't properly displaying required materials, requests, or the list appears clipped and only on part of the screen. More is visible when changing the size of the screen or the in game UI scale setting but not enough to be effective, resulting in workers unable to work and sometimes holding the block they need in their hand rather than doing anything. Requests aren't showing up in their UI at all. Assuming again that it's a UI error because occasionally I'll see the request in chat, which I know we can configure to different intervals, but isn't conducive to efficient filling of requests. Screenshot gives and example of the issue with the most visibility of the materials list I was able to achieve.
Steps to reproduce the problem
- Open Villager/Hut block interface
- Select Required Resources or Requests
- List of requests/resources is either blank, clipped, or unreadable
EDIT: First time using GH for issue. Had to remove commented text
I tried that previously. Scaling the UI does seem to change how much of the list is visible. The screenshot is with the UI and window size scaled in such a way that I was able to see the most of the list. Any other size/scale made it completely invisible.
So I ran it on Windows with Java 8 U231 (same version I have on macOS), the same version of minecolonies, and the same version of structurize with no issue with UI. I'm only having the issue when I run the mod on my macOS version. When running it on Windows, I messed with GUI scaling, window sizing, and my graphics settings and it worked fine in all cases. When tinkering with the window size, resolution, and GUI scaling on macOS I was unable to find a usable setting. The screenshot is still the best representation of what I was able to accomplish.
hm thats quite a weird issue, could you try using this java on your mac?https://adoptopenjdk.net/releases.html#x64_mac
@Raycoms Fresh DLs of both mods and the issue persists.
@someaddons I've installed that JRE and am unsure of how to make sure it's being used. Sorry if that's a simple thing
in the launcher under instance settings advanced you can choose the path to the java executable to use
I got to that part, just unsure of where the JRE installed... Or should I just download the manual one and choose the .tar.gz?
Ok I finally figured out how to run the custom (not bundled) java... UI error is still occurring.
Also I really appreciate y'all's patience in helping me with this. I would love to be able to just run it on Windows but my work requires me to multitask in macOS and I have Windows bootstrapped onto the same laptop. I really love the mod because I can let the villagers build while I work and just check for requests every now and then. My only problem is that I can't see the requests without the UI working properly for me and the server I run for my friends and coworkers is in 1.14.4 so I don't have the option of simply running 1.12.2 :(
Having similar problems when trying to build in creative (480 alpha that is in the patreon test pack, windows 10)
When I click with build tool, it only shows the top two huts alphabetically I have in my inventory, scrolling down, it starts to show most of them, but not all.
This is what it looks like when I first click with tool, you can see all the huts i have in my inventory (only have the ones in tool bar) which include the townhall, and warehouse.
This one shows when I scroll all the way to the bottom - there's the blank space there for the other names, but they don't appear, and clicking in that space does nothing.
If I select lumberjack at the end, then click the right arrows up the top, it scrolls through to decorations, townhall and warehouse - but they still don't show in the drop down text
(edited for formatting)
...and was going to go test if I had the same error in the builders hut, but I placed the townhall and builder, made the lumberjack ready to be built, but can't access anything in my colony. Tells me I have no permissions to do anything, even though /mc whereami says I am in my colony. I am entirely too fuzzy headed to even START to work that one out, so I can't test the builder =P
Should be noted that this issue is reproducible on both single player and a dedicated multiplayer server
I'll check into this tomorrow, our maven repo is broken and I can't get our deps atm
I added a performance improvement to the list and only tested the postbox, so I gotta check some other lists too and check which ones "broke" =D
I just tried it and wasn't able to reproduce this.
- On which structurize version are you?
- Can you tell me the steps exactly on how to reproduce this?
- structurize-0.10.194-ALPHA
- It is a consistent issue for me every time I open an interface that contains any sort of list. I am running on mac so I will attempt to run it on Windows and see if I experience the same issue.
I am having the same issue as the screenshots above with the left drop down not showing all huts in inventory...even after scrolling to see more. clicking the left/right arrow allow all to be found...but not listed. additionally, sometimes the list for upgrading a building is not shown unless i choose another and go back.
Windows 10, minecolonies-0.10.483-BETA-universal and structurize-0.10.194-ALPHA with forge version forge-1.14.4-28.1.69.
If i change back to structurize-0.10.193-ALPHA, then the GUI problems all go away.
Edit: Tested with structurize-0.10.195-ALPHA and menus populate and scroll as expected.
- Tested with MC .472 and Struct 193, Works as intended on Mac 10.13.6 with Forge 28.1.61
- Tested with MC .483 and Struct 194 works as intended same Os and Forge.
- Tested with MC .483 and Struct 195 works as intended same Os and Forge.
All tested with Java 1.8.0_74 64bit. OP issue could not be replicated.
Video Settings: GUI Auto 800x600@60
The problem I was having up there, I've made a separate instance of the mod, using MC 484 and structurize 195 and it's behaving as expected.
Using all the same settings you listed. Same java, MC, Struct, OS, forge, and still getting the issue. No clue what the cause is at this point. Guess I'm just playing on Windows instead. Sorry to have wasted y'all's time.
I have been following this issue as it affects me as well, and I am sure others like me. I have a Mac and am not able to switch to a Windows machine. I would like to have this issue reopened and corrected. Please?
I have been through all the above suggested steps in correcting the issue to no avail.
minecolonies-0.10.493-RELEASE-universal
structurize-0.10.194-ALPHA
forge-1.14.4-28.1.76
Since we can't debug this locally, not even on a MAC.
Can you run this structurize jar, open a few GUIs and send me your client log?
How do I override/get around the forge error?
"Mod mine colonies requires structurize 0.1.192-ALPHA or above
Currently, structurize is 0.10.16.3-PERSONAL"
Nothing out of the normal there
https://teamcity.minecolonies.com/guestAuth/repository/download/LetSDevTogether_Structurize_Branches_Build/32385:id/build/libs/structurize-0.10.164-PERSONAL.jar
Please try this one again
Struc 0.10.164-PERSONAL
MC 0.10.1389-PERSONAL
Same issue is occurring. Drop-downs are blank for the structurize GUI but the scroll bar appears.Any scrolling GUI for MC is blank or clipped at the top covering around 90% of the area the list should show up in, just like the original screenshot posted
https://www.mediafire.com/file/wk87yz9ub2e0d5e/debug.log/file
https://www.mediafire.com/file/sbsclolgilh3j5k/latest.log/file
https://www.mediafire.com/file/ueoumia1pp9daoj/debug-1.log.gz/file
I hope these are what you need and are helpful in resolving ... let me know if there is anything else I can do to help.
@Megistus please upload the files normally to Github or put them in a https://gist.github.com
This is what I am running:
Model Name: MacBook Pro
Model Identifier: MacBookPro14,1
Processor Name: Dual-Core Intel Core i5
Processor Speed: 2.3 GHz
Intel Iris Plus Graphics 640:
Chipset Model: Intel Iris Plus Graphics 640
Type: GPU
Displays:
Color LCD:
Display Type: Built-In Retina LCD
Resolution: 2560 x 1600 Retina
System Version: macOS 10.15 (19A602) ** Had this issue with macOS 10.14 **
Other than that ... dunno what driver versions you need. Not like Mac's can tweak on updating drivers like a PC can.
Java Version 8 Update 161 (Minecraft 1.14.4)
Mac Version 10.15
Intel Iris Plus Graphics 650 1536 MB
@Sharkykzn @Asherslab compared to your settings, anything significantly different?
The issue can be fixed if the user switches to Fullscreen. The GUI misplacement happens in windowed mode under macOS.
Same Issue on the 1.14 version
Mac Intel Iris 655
(Oracle)Java 8 update 231
Forge 28.1.90
Minecolonies - 0.10.556-ALPHA
Structurize - 0.10.199-ALPHA
This is not the case. I have tried starting in fullscreen, switching to and from fullscreen, and a reasonable number of variations of resolution, but the issue persists as in the original screenshot.
Minecraft 1.14.4
Mac Intel Iris 6100
Java 8 U231
Forge 28.1.90
MC 0.10.522-BETA
Struc 0.10.199-ALPHA
Okay, amazing, so not only is it not consistent over MACs but also on some MACs does only display in windowed mode =D
Have you tried to install Optifine? Initially I installed it and switched to fullsceen while using the mod, removed it and now there are no issues in fullscreen. I wouldn't rule out optifine did something even after deletion.
Running it with Optifine produced the same issue with fullscreen and windowed. Following the uninstall of Optifine the issue persisted in fullscreen and windowed.
Hi guys, the issue mentioned above ldtteam/minecolonies#4102 is mine. Happy for it to be merged into this one. Anything I can do to help with getting this working, just let me know.
Hmm, posting my system in case it's helpful.
MacBook Pro (Retina, 15-inch, Mid 2015)
2.2 GHz Quad-Core Intel Core i7
RAM: 16GB
Intel Iris Pro 1536 MB
Changing the GUI scaling doesn't do anything for me. Seems to be tied to the change of the fullscreen resolution for me.
I got around this one finally. It seems to be something funny with resolutions and fullscreen. Instead of using the maximise button (green button top left) use the in-game option to fullscreen. This fixed it for me. :)
As a note, I’m on a Mac, never had an issue at all, using Green button, in game maximise, windowed, or otherwise. So I’ve no clue what’s going on here nor can I debug it.
Will note, I always play with the GUI scaling set to normal/medium/whatever-it’s-called, not auto or etc. that may be what’s going on here?
I just tested mine colonies on my wife's older Mac. It works as expected. Upon other searching ... this seems to be a MacBook Pro Retina issue (found mention of issue with other games and their UI's). Hope this helps as maybe a way forward.
We still can't reproduce this any way, maybe @Asherslab will be able to reproduce it somehow on his Mac. Without reproducing it, it's impossible to fix it unfortunately.
I am having this issue on my Mac. Won't work on an external monitor in any setting. On my laptop screen the contents are only visible when running in full screen mode.
For twitch launcher users and mc 1.13+: can you look into launch settings/at the beginning of latest.log and make sure that java arguments/flags contains -XstartOnFirstThread?
I doubt it can help but twitch is broken so let's be sure
Fix is only when in full screen but thats not really a fix
is Minecolonies using a lib for the lists?
To be fair, I debugged this these days with a user that has this same issue. This has appeared in minecraft 1.14 forward. So there is a good chance this is a forge/openGL/minecraft issue.
the problem is if youre monitore is too big the UI breaks
thats why its not on every mac because of the monitor size
my breaks because i have a 15' screen and its breaks even in fullscreen but when i set down the resolution it works
can you provide screenshots while holding left ctrl (super key for mac)+shift+alt (should display blue boxes around elements) for different gui scaling?
well its because of the high resolution ist there a overflow problem or something?
because scrolling is not broken on other mods / vanilla
The weird thing is that this only happens for Macs, windows and linux users don't have any issues.
Well, ty for screenshots, that's really weird thing (= I don't know what to test now)
i tried a mod thats adds controller support (controllable)
and has the same bug but in a diffrent way
in window mode it only allowed to move a max area
can this help?
I am going to make an educated guess based on what I see here.
Given that this happens with some very special controls, all of them use scissoring to limit the rendering area, i am going to make a guess that this logic is broken.
We might possibly be using the scaling calculation wrong, or MacOS is returning the wrong information. I had this issue in SmithsCore and build in a Debug mode for this special purpose.
The new BlockOut also contains this debugging mode, however the old BO does not. We should compare the Implementations of the Scissoring in the Old and New BO to check.
Anybody in here, with a mac and which have the issue: We are collecting data on the issue: Please run this Structurize jar: https://teamcity.orionminecraft.com/repository/download/LetSDevTogether_Structurize_Branches_Build/36380:id/build/libs/structurize-0.10.207-PERSONAL.jar
In a creative super flat world:
- Grab a scan tool
- Left click a block, right click another block then right click in the air.
- This opens the scan UI.
- Make a screenshot
- Press "Show Resources"
- Press "Replace" on any one of the displayed resources
- This opens the replace UI
- Make another screenshot.
- Close all UIs by pressing the red crosses
- Once back in game, press F3 to open the Minecraft debug screen
- Create another screenshot.
- Open your system information, see here (https://support.apple.com/en-us/HT203001) and create a screenshot from your Overview tab. Please remove your Seriel Number from this screenshot, by editing it. We are not responsible for you disclosing that piece of information if you forget and upload it! The important parts:
Then 13) Upload all of these 4 screenshots here!
Yes we know the UIs look potentially weird. But we have enabled some debugging layers to show us more information.
Here are my screenshots.
Archive.zip
@PowerSchill Did you have the issues previously?
And do you still have them now?
Except for the weird block textures (those were added in this test version to see additional control information)
Okay ONLY the mod nothing else;)
Cool this means we have a fix because in the latests alphas we have still the ui issues
LOVE IT! :D
@lucsoft @PowerSchill Did this actually fix it or not?
@lucsoft @PowerSchill Did this actually fix it or not?
Well yes this list works
And the alpha version (both together) doesn’t