Structurize version

Version: version/1.15 branch (I built from source to make sure it wasn't fixed in a recent source code change)

Problem

Line 91 and 95 comment out variables with //todo inside the optifine compatibility layer.
The line below each of those 2 lines, reference those commented out variables, thus, when the compatibility layer gets loaded; it crashes and fails to load during forge bootup.

When I commented out the 2 lines referencing the commented out variables, the game loads up correctly and OptiFine actually works with shaders and everything :)

Steps to reproduce the problem

1. Add the latest OptiForge version
2. Add the latest Optifine preview
3. Boot the game
4. Fails to boot

Ok, will trust your research and push that in.

@T-Grave with those two disabled do the schematic display correctly?

@Nightenom @Raycoms

I do have to admit, I did not actually test all mods extensively, I was just happy I was able to load up a world in the Valhesia 2 modpack after patching this, with shaders.

I expect there could still be rendering issues (seeing as there was a //todo and we're essentially turning off parts of the compat layer). But I'd argue it's still an improvement over not being able to launch at all.

Can you explain me what I should test exactly @Raycoms then I will do so right now? (I'm sorry, I have not yet played the Structurize mod myself in this modpack, only started playing with it recently)

Actually I'm not aware of using those methods rn (in the rendering pipeline), so basically it should not work as intended or optifine itself hasn't ported this part yet
Mostly we need that for preview thing which you can access using buildtool (gold scepter)
edit: yeah, no signs of using it anywhere https://github.com/ldtteam/Structurize/search?q=OptifineCompat&type=Code

@T-Grave basically right click the buildtool to test if the previews render correctly.

@Nightenom I pushed a fix for it right now.

Does it actually do anything? Since it's not used we don't need to call it
If it works out of the box (which it may) then it's ok, but I doubt

I'm not sure it is doing anything at all atm. It would have to be tested.

I will let you guys know in a few minutes :)

Edit: I'm sorry guys, taking a bit longer, was doing a fresh install of the modpack, enabling shaders takes a while the first time 🥇

I expect it's supposed to preview something here?

This is without the latest patch you pushed @Raycoms

yeah its supposed to render the fortress cornerkennel somewhere around there

Move it around with the arrows up and down a bit to see if it appears somewhere

Don't think anythings happening. Also pressing the green mark never does anything and throws a "Cannot build" error in the console. Pressing the "copy/paste" buttons does actually make a huge structure appear.

Should I try with your latest patch?

If there wasn't a preview in the place of the structure (before you placed it) then it's not working
You don't need to, it won't change anything

So I guess we don't support optifine in 1.15 yet =P

We're rendering those things on the vanilla layers now though, so that's weird.

I did one last test for you guys: using OptiFine but without any shaders enabled. Lots of folks love to use optifine for the FPS boost it gives, not necessarily for the shaders.

But it looks like the previews aren't working in that case either.

Can you try the version that I just pushed? (Will be on curse within minutes)

Will do

Tested with 0.293-ALPHA: The game boots up fine with OptiFine enabled, shaders work, preview doesn't.

Even without shaders the preview doesn't load?

@T-Grave which optifine version are you using? I can't get preview_OptiFine_1.15.2_HD_U_G1_pre12 working (crash when loading). If it's a different version please upload it somewhere and send to me.

Also which and where you got your shaders so I can test them

Can you try this if it works?
https://teamcity.minecolonies.com/guestAuth/repository/download/LetSDevTogether_Structurize_Branches_Build/36551:id/build/libs/structurize-0.10.211-PERSONAL.jar

@Nightenom I was using pre10, are you using OptiForge and MixinLoader as well? You need those to make optifine work on forge atm (no official forge support yet)

Going to sleep now, but I will try tomorrow and let you know.

Nope, it gets even worse with the mods you suggested, however, you should be able to run it outside dev space

@T-Grave can you please test the version above?

@Nightenom I'm sorry for the delay, got very busy for work.

Just tested, same result as before; previews not working.

In terms of getting Optifine to work locally for yourself: another important variable was the Forge version, it has to be >=31.1.32

@T-Grave @NiickNICHEN @theoklm new version to try, if this one won't work I'm gonna make another try when optifine team manages to publish forge compatible version
https://teamcity.minecolonies.com/guestAuth/repository/download/LetSDevTogether_Structurize_PullRequests2_BuildAndTest/37124:id/build/libs/structurize-0.10.151-PR.jar

@Nightenom no improvement :(

Totally understand you wanting to wait , will be a lot easier to fix once you can test it properly yourself :)

Thanks for trying tho!

Nightenom, I tried your structurize-0.10.151-PR with MixinBootstrap-1.0.2.jar, OptiForge-MC1.15.2-0.1.11, preview_OptiFine_1.15.2_HD_U_G1_pre13, It displayed the preview in game fine while in creative, but would not even give me a menu when trying in survival, I used both SEUS-Renewed-v1.0.1 and Sildurs Vibrant Shaders v1.27 Extreme-VL shaders I just figured i would post my findings, thanks for all the great work you guys put into this mod.

thanks for the info, that's really weird it works in creative while not in survival, BUT at least it works :)

@Nightenom I realized i did not have the most recent version of Structurize my first time trying.
This setup works for me, I hope the OP can use it.

forge-31.1.47

OptiForge-MC1.15.2-0.1.11
MixinBootstrap-1.0.2
preview_OptiFine_1.15.2_HD_U_G1_pre13
structurize-0.10.302-ALPHA
minecolonies-0.11.840-BETA-universal
jei-1.15.2-6.0.0.3

Shaders i tested
SEUS-Renewed-v1.0.1
Sildurs Vibrant Shaders v1.27 Extreme-VL

@TaylorMaker54 so it works with the current latest version?
or with the one I posted recently (structurize-0.10.151-PR.jar)?

@Nightenom Yes. The current at the moment i believe is structurize-0.10.302-ALPHA and it does work