Allow for arbitrary entity placing logic similar to block placement
dupontct opened this issue · 4 comments
Prerequisites
- I am running the latest alpha version of Structurize for my Minecraft version.
- I checked the MineColonies/Structurize wiki and made sure that my issue is not covered there.
- I made sure that this change request is not a duplicate of any existing change request.
Context
- Minecraft Version: 1.16.5
- Structurize Version: 0.13.174-ALPHA
Is your feature request related to a problem?
Placing entities in non creative mode using Structurize is currently very limited. In ldtteam/minecolonies-features#447 I would like a way to have a book and quill or written book with custom text placed inside of an item frame.
I as I understand the code this is not possible given the way that Structurize is currently coded.
Enhancement or Change description
A system similar to the IPlacementHandler block placement system, but for entity placement would greatly enhance the flexibility of entity placement in mods using Structurize.
This would allow the creation of an entity handler that would consume a blank book and quill and place a item frame containing a book and quill with the custom text.
Notes or related things
Viewers
- Add a thumbs-up to the change request to vote for it. This helps the request become more visible to the team and doesn't clutter the comments.
- Add a comment if you have any insights or background information that isn't already part of the conversation.
Honestly, item frames with anything should work, if they don't, then it's a bug (regardless of survival/creative mode).
The second problem you mention, that is placing item frame should also require the item inside the frame, is generally problematic because each entity/tile entity has different access to its inventory. It's something that is being considered during development of the next structurize major version, also with addition of entity placement handlers
A thing for replacing requirement of book&quill with just a book is in one the open PRs (needs some polishing)
Item frames do work with anything.
The problem is that the item frame requires the exact same book and quill as when it was scanned. So if one scans a structure with a book and quill that has the text "test" written in it contained in a item frame. The builder will refuse to use a blank book and quill. The builder needs a book and quill that is identical to the book and quill in the scanned structure. So the builder needs a book and quill that has the text "test" already in it. This requires the player guess what was in the book and quill to begin with.
Which defeats the purpose of a using a book and quill as a readme describing how to use a structure. 😁
I'll see if doing this is within my coding abilities and submit a PR if it is.