Solid block need redefinition for placeholder
leagris opened this issue · 0 comments
Prerequisites
- I am running the latest alpha version of Structurize for my Minecraft version.
- I checked the MineColonies/Structurize wiki and made sure my issue is not covered there.
- I made sure that this issue is not a duplicate of any existing issue.
Context
- Minecraft Version: 1.16.5
- Structurize Version: 0.13.210-ALPHA
- MineColonies Version (if related bug): 0.14.350-ALPHA
- Related Mods and their Versions: -
Expected behavior
Blocks which are not solid at their side (not accepting wall torches) shall not classify as solid block for the solid blocks placeholder.
Either a block shall only be considered solid if it accepts hanging blocks on its side.
Or the solid placeholder shall not accept hanging blocks on its side, so schematic builders would avoid placing torches, item frames, paintings on the side of solid placeholders.
Corollary, the light (air) placeholder block shall not be solid to reject anything hanging or placed over it.
Actual behavior
When a wall torch or other wall hanging block like vines, ladders, item frames, paintings… are placed against a solid block placeholder in a schematic, the schematic might not be able to be completed by builder or miner if solid placeholder is filled by a block that cannot sustain hanging.
The default wooden miner nodes schematics in Minecolonies has a wall torch on some of the nodes that is hanging against a solid placeholder block.
When miner build across a Minecraft mineshaft with fences, fences are wrongly left as solid block by the placeholder. Miner tries to place the torch on the side of leftover fence block, fail, try again and get stuck in an endless loop.
When builder rebuilds the medieval dark oak tavern directly at level3 after the hut has been picked-up at that level, air placeholder blocks cannot support the two item frames. It would be no issue if the schematic was unbuildable with the air placeholder denying the hanging of item frames and a solid placeholder was used instead with warranty that the solid replacement blocks is also capable of hanging item frames.
Steps to reproduce the issue
- Let mine expand to existing vanilla Mineshafts
- See fences and cobwebs accepted as solid block from the placeholder
- Eventually see miner endlessly fail to place torches on these
Logs
- latest.log:
- crashlog:
Notes
Viewers
- Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
- Add a comment if you have any insights or background information that isn't already part of the conversation.