[1.16.3] sulfur-potassium-mod is not registering the two configured features of the ores
TelepathicGrunt opened this issue ยท 1 comments
Hello! I was test running my mod called Blame to see how well it works on modpacks and it seemed to have found that sulfur-potassium-mod does not register the ConfiguredFeatures of the ores. This can be an issue for mod compatibility as under certain conditions, unregistered ConfiguredFeatures can basically prevent other mod's registered ConfiguredFeatures from spawning if in the same generation stage.
By that I mean, if mod A adds an unregistered CF to the ore generation stage and the biome's codec reaches it first, it will choke and basically nuke mob B's registered CFs afterwards. Here's a case where BetterCaves forgot to register their CF and caused several CFs from Oh The Biomes You'll Go to stop spawning in the world: YUNG-GANG/YUNGs-Better-Caves#75
Here's a more detailed explanation of why this happens in the biome's codec:
Specifically, when you call .withConfiguration on a Feature, you create a ConfiguredFeature. This is what should be registered to the WorldgenRegisties at mod init (you can do it in FMLCommonSetupEvent so you have your config ready too if it is needed).
Anyway here's an example from my mod RepurposedStructures of me registering all my ConfiguredFeatures.
https://github.com/TelepathicGrunt/RepurposedStructures/blob/a4e3365e3867b8510952ebf658c415de6e412927/src/main/java/com/telepathicgrunt/repurposedstructures/RSConfiguredFeatures.java#L184-L185
I hope this helps!
The CFs that Blame found that are unregistered are these. It pulled those entries out of the CF's JSON to try its best to find which mod the CFs are from:
sulfurpotassiummod:potassium_ore_block
sulfurpotassiummod:sulfur_nether_ore_block
sulfurpotassiummod:sulfur_ore_block