[SBW] Superb Warfare

[SBW] Superb Warfare

Mods
16.2k Downloads

`MobileVehicleEntity#baseCollideBlock` destroys blocks even if `VehicleConfig.COLLISION_DESTROY_BLOCKS` is false

Closed this issue · 2 comments

commented

The MobileVehicleEntity#baseCollideBlock method destroys blocks such as leaves and lily pad even when VehicleConfig.COLLISION_DESTROY_BLOCKS is set to false.
This behavior should be controlled by the config, like in the collideBlock method.

SuperbWarfare/src/main/java/com/atsuishio/superbwarfare/entity/vehicle/base/MobileVehicleEntity.java

Lines 506 to 518 in 294c485

public void baseCollideBlock() {
if (level() instanceof ServerLevel) {
AABB aabb = getBoundingBox().inflate(0.25, 1, 0.25).expandTowards(0, 0.5, 1).move(this.getDeltaMovement().scale(1.2));
BlockPos.betweenClosedStream(aabb).forEach((pos) -> {
BlockState blockstate = this.level().getBlockState(pos);
if (blockstate.is(Blocks.LILY_PAD) ||
(blockstate.is(BlockTags.LEAVES) && blockstate.hasProperty(LeavesBlock.PERSISTENT) && !blockstate.getValue(LeavesBlock.PERSISTENT)) ||
blockstate.is(Blocks.COBWEB) || blockstate.is(Blocks.CACTUS)) {
this.level().destroyBlock(pos, true);
}
});
}
}

SuperbWarfare/src/main/java/com/atsuishio/superbwarfare/entity/vehicle/base/MobileVehicleEntity.java

Lines 520 to 529 in 294c485

public void collideBlock() {
if (!VehicleConfig.COLLISION_DESTROY_BLOCKS.get()) return;
AABB aabb = getBoundingBox().inflate(0.25, 1, 0.25).expandTowards(0, 0.5, 1).move(this.getDeltaMovement().scale(1.2));
BlockPos.betweenClosedStream(aabb).forEach((pos) -> {
BlockState blockstate = this.level().getBlockState(pos);
if (blockstate.is(ModTags.Blocks.SOFT_COLLISION)) {
this.level().destroyBlock(pos, true);
}
});
}

commented

Acturally I've complained with them about this for multiple times, but they just keep saying "No we think vehicles should just break these blocks, otherwise they won't drive smoothly".

Anyway, I'll add related config to turn this feature off.

commented

Fixed in 0.8.6

  • ❤️1