SuperMartijn642's Core Lib

SuperMartijn642's Core Lib

Mods
101M Downloads

[Crash] Access Widener conflicts with Dream Burst Spirit Vector

Miasmusa opened this issue ยท 0 comments

commented

Version Info

  • Dream Burst Spirit Vector [1.10.5+1.21.1]
  • Fabric API [0.115.2+1.21.1]
  • No Telemetry [1.9.0]
  • SuperMartijn642's Core Lib [1.1.18+a]

Steps to Reproduce
Install Dream Burst Spirit Vector alongside this mod.

Crash report (~/logs/latest.log)
https://mclo.gs/hIfxUn9

More info
This is caused because of the following access widener:

SuperMartijn642sCoreLib/src/main/resources/modid.accesswidener

Line 12 in 75b53cc

accessible method net/minecraft/client/gui/screens/inventory/AbstractContainerScreen renderFloatingItem (Lnet/minecraft/client/gui/GuiGraphics;Lnet/minecraft/world/item/ItemStack;IILjava/lang/String;)V # renderFloatingItem

Dream Burst Spirit Vector overrides this method, but applying the access widener changes the method to be final, causing the crash. The fix would be replacing the AW with an invoker, which would be best practice here regardless (AFAIK).