Supplementaries

Supplementaries

82M Downloads

Compat; Bypassing Forge Event callbacks

simibubi opened this issue ยท 3 comments

commented

Greetings o7
We found a funky interaction:

Create subscribes to forge's interact events for in-world filter slots.
Supplementaries subscribes to the same event in order to handle the placeable sticks feature.

Its handler's high priority setting causes it to run first:


The sticks' placement feature skips interaction event handling by asking the blockstate for an action result directly
result = blockstate.use(world, player, hand, raytrace);

Therefore, if a block returns != pass, all modded interact handlers that do not claim 'highest' priorities are skipped.
Ultimately this means any item made placeable in new ways will not be accepted as filters on a handful of Create blocks such as the funnel.

My suggestion would be to consider the new placement options a low or lowest priority handler, as sneaking should bypass most interaction handlers added by other mods.
Feel free to ask if you need more details, or to close if you consider this a non-issue.

Cheers!

commented

Thanks for the report, I've set it on low priority and tested it with a basin and works fine. Having lower priority makes sense since block placement actions like I am doing should come after other block interactions.

Oh since we are talking about placeable sticks I wanted to take the opportunity to suggest also taking a look at Creators-of-Create/Create#2149, which sparks from the need for my placeable sticks to be viewed as 3 stick item instead of their block item. I know you guys have so many issues there so that might have gone under the radar. It's nothing major tho so no hurry :)

Cheers

commented

oh that's a good point. I'll try fix it accordingly

commented

Will do, thanks ๐Ÿ‘