Supplementaries

Supplementaries

Mods
82M Downloads

[🐞]: Several Post Effects (shaders) are immediately removed when `mob_head_shaders` is enabled.

mortuusars opened this issue · 1 comments

commented

Before Continuing:

  • Check you are using the latest version of the mods and its dependencies
  • Always include a latest.log if you are crashing
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version

1.20.1-FORGE

Supplementaries Version

supplementaries-1.20-2.8.17

Moonlight Lib Version

moonlight-1.20-2.12.6-forge

Issue Detail

If the shader, that is defined in ClientEvents#EFFECTS_PER_ITEM, is applied but player is not wearing the appropriate head - effect is immediately removed.
This breaks mods that apply that shader for their purposes.

It was reported to my mod (Exposure) because in latest version I've added a filter that uses vanilla invert shader.
I'll fix this particular issue by creating my own invert shader instead, but since filters for Exposure can be created/modified in a resourcepack - players might run into the same problem when using creeper or desaturate shaders, for example.
And other mods can potentially be affected by this as well.

commented

I've changed the code a bit. hopefully this should catch this

  • 👍1