Not compatible with Mohist
deceased-a opened this issue ยท 12 comments
I tried installing your mod on Mohist 1.16.5 but it crashes.
MohistMC/Mohist#1761
Honestly I have no idea how to even approach this. It seems like mohist is a huge core mod that changes a bunch of vanilla methods and stuff so it's very likely that it caused some issues. I'll try to see what I can do
We also have this issue
Stack Trace
Oh. Looking at the actual jar code I see you intentionally divide by zero to crash. I removed my blobs since its not relavent
Here is a full debug log for a server running Mohist and your mod, it appears that it happens after recipes are registered? You'll need to click the thing at the top since the file is too large for the normal GitHub view of it
If you can add some logging to the mod, I can run it on my server and see where exactly it fails to initialize. Not sure why that already doesn't exist since at the moment you just have a binary output of "It worked" or "It didn't" in a long list of initializing steps.
If I had to make a guess it has to do with your mixins, Mohist likes to break with Mixins. If that's the case, its on them to fix it probably. You should still add logging to see exactly what is breaking
Oh I've included a bunch of logging next update which will come out shortly so I can better debug this
Yeah I'm intentionally crashing cause I kept getting weird errors when mod setup failed. Since mod setup is multithreaded it doesn't throw errors when it fails and instead keeps on going. this can cause all softs of issues, most noticeably if it doesn't get past structure registration it can nuke worlds. Id mod setup fails then the mod shouldn't continue booting in a half working state and instead should close since that way one knows that there's something going wrong
Thank you, I appreciate it. I will let you know if I get a chance to confirm the issues, Mohist has since updated their Mixin version to fix a lot of bugs regarding it so it could already be fixed. I am testing the version that comes with the latest ATM6 update shortly
OK, It appears the latest update of Mohist (Build 800+) has fixed this issue. Thank you for adding the logging though, it can drastically help to fix issues like this faster!