Supplementaries

Supplementaries

114M Downloads

[๐Ÿž]: Tom meme played if a cat without name "Tom" is on a turn table

donmor opened this issue ยท 1 comments

commented

Before Continuing:

  • Check you are using the latest version of the mods and its dependencies
  • Always include a latest.log if you are crashing
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version

1.20.1-FORGE

Supplementaries Version

supplementaries-1.20-3.1.6

Moonlight Lib Version

moonlight-1.20-2,13.42-forge

Describe Issue

It is said that a cat named "Tom" sitting on a turn table triggers a meme, but it can be triggered by any cat.

I found there's no entity name detection code in the master branch:

// common/src/main/java/net/mehvahdjukaar/supplementaries/common/block/blocks/TurnTableBlock.java:194-202
                if (e instanceof Cat cat && cat.isOrderedToSit() && !world.isClientSide) {
                    if (world.getBlockEntity(pos) instanceof TurnTableBlockTile tile) {
                        int catTimer = tile.getCatTimer();
                        if (catTimer == 0) {
                            tile.setCat();
                            world.playSound(null, pos.getX() + 0.5, pos.getY() + 1f, pos.getZ() + 0.5, ModSounds.TOM.get(), SoundSource.BLOCKS, 0.85f, 1);
                        }
                    }
                }

commented

it wanst intended to only work with cats named tom.the condition is already very niche its very very unlikely for somebody to stumble upon it by chance already. adding name check will make it even more obscure