[🐞]: Book piles have missing texture upon rejoining world
Closed this issue · 13 comments
Before Continuing:
- Check you are using the latest version of the mods and its dependencies
- Always include a latest.log if you are crashing
- Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue persists.
- If you are unsure which mod is the culprit.
Disable all of your mods and enable them 1-2 mods each time to isolate the culprit - Confirm that there is no existing issue with a similar description submitted in the list of issues.
Version
1.21.1-FABRIC
Supplementaries Version
supplementaries-1.21-3.1.8
Moonlight Lib Version
moonlight-1.21-2.18.13-fabric
Describe Issue
Although a similar issue has been reported prior, the conditions do not line up with the previous report. On a minimal set of mods installed, book piles that have been placed appear fine. Upon rejoining the world, the each book turns into a missing texture block. May be related to missing book type warning in log file. Attempting to use F3+T does not fix or affect the issue.
Log: latest.log
That's odd. I hope it's not anything specific to my hardware configuration. Out of curiosity, which Fabric loader version and Fabric API version did you use to try to recreate it?
0.110.0+1.21.1
doubt its that tho.
So /reload makes this bug appear? are you on a server?
My wording might have been incorrect. I don't know about /reload, but it happens when I save and quit the world in singleplayer and reopen the world.
oh, sorry. I tried using /reload and it didn't affect any textures. Instead, I couldn't place down books at all until I rejoin the world. This is in singleplayer not on a server. thank you so far for your replies and help.
log: latest.log
I have heard very very few with an issue similar to this. If you are just using the mod alone i have no idea what could cause it
It seems like it is Fabric specific. Tried replicating in NeoForge and couldn't recreate the issue.
In my own testing, looks like a race condition between ClientReceivers.handleSyncBookTypes() setting up the itemToBooks map and PlaceableBookManagerClient.getValidModelsForBookItem() looking up the BookType in the map.
TLDR; I think sometimes it tries to read from the itemToBooks map before it is set in that instance for the client. Not sure why that's Fabric-specific or why it happens, but it did.
I'm also running into this on a NeoForge 1.21.1 server. Rejoining works to fix it, and it only happens randomly to different people. I'm not sure what logs I should provide here or if they would be helpful.
