
Some tags missing
Closed this issue ยท 29 comments
Lumisene Bottle needs #c:drinks and #c:drinks/lumisene
do not give it #c:foods tag though, as that's only for things that provide hunger points
they might also need the #create:upright_on_belt tag and maybe #create:deployable_drink tag, unless you somehow only apply those if create is loaded (it isn't in my pack)
1.21.1 btw
any other deployable_drink and upright_on_belt I should add?
I don't think so, Supps doesn't add many bottles as far as I can see (I'll check for other things though)
and idk what safe_nbt is used for, never seen it
globes maybe should be #minecraft:piglin_loved (item tag) - they look pretty golden to me
bombs and blue bombs should be given the #lychee:item_exploding_catalysts item tag (not block exploding as they don't break blocks)
vanillabackport:pale_moss_carpet, deep_aether:aether_moss_carpet, and deep_aether:cloudbloom_carpet are all missing from the #amendments:stairs_carpets block tag (ok this is an amendments thing but still shouldn't be too hard to fix right)
pancakes are also missing the #c:music_discs tag, unless i'm missing something and they're no longer music discs?
did i mention already that ash bricks are tagged as #c:ingots/brick when they should be tagged #c:bricks and #c:bricks/ash already?
deep_aether:golden_swet_ball should be tagged as #supplementaries:throwable_slimeballs but this may be because they haven't tagged it as #c:slime_balls
flax (or flax seeds) should maybe be tagged as #minecraft:llama_food as they do eat that irl
What's the discriminator for upright on belt? Also I could swear I had that tag already
for upright on belt i think it's just what makes sense irl for it to be upright - you'd store bottles upright so they don't leak
also because you'd fill them with a spout so it makes sense the stopper is on the top for the fluid to pour in from the spout
ofc antique ink isn't a liquid, but it makes sense and it'd be weird if it lay down sideways next to similar bottled-looking things that were standing up
redstone sconce might be missing the #create:brittle tag that the other 2 sconces have unless that's intentional
Brittle is also related to stuff that breaks when moves but I'm not sure about it there might be more there missing
a few modded entities are missing the #supplementaries:eats_fodder entity tag
goated:geep
buzzier_bees:moobloom
friendsandfoes:moobloom