Supplementaries

Supplementaries

127M Downloads

[๐Ÿž]: Cranks do not send full block updates when turned, potentially causing mod compats

Closed this issue ยท 14 comments

commented

Before Continuing:

  • Check you are using the latest version of the mods and its dependencies
  • Always include a latest.log if you are crashing
  • Remove known hacky mods such as: Optifine, Fabric API/Connector on forge, and every kind of hybrid server like Mohist and Velocity. None of these are supported. Also try without other lesser usual suspects like Sodium and Lithium.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version

1.20.1-FORGE

Supplementaries Version

supplementaries-1.20-3.1.39

Moonlight Lib Version

moonlight-1.20-2.16.13-forge

Describe Issue

8mb.video-mij-gJMGAJ6O.mp4

Powering a resistor (from Caverns and Chasms mod) with a supplementaries crank makes the resistor redstone power not update. This isn't a proper mod incompat because resistors are not public yet in caverns and chasms. Dev of caverns and chasms says that crank aren't updating blocks as aggressively as they should and should cause other unintentional behavior, so it's something that is could more appropriately fixed in supplementaries's side. Was unable to find any more mod incompats

team-abnormals/caverns-and-chasms#169

commented

many questions:

  • what does "update as aggressively as they should" mean? Cranks send block update to all around pus to the one behind
  • does it work with levers? because cranks are a clone of levers code wise, I checked and its basically all the same
  • do those resistors function just like a comparator in subtract mode?
  • ive tried many other blocks and they all react ok. if thats a block fron a mod not on curse foge this issue is invalid, i dont support payed mods.
commented
Image

do those resistors function just like a comparator in subtract mode?

Yeah, but neither levers nor cranks can be power the side of a comparator by their own. And when cranks turn off, go from 15 to 0 that updates the redstone fine. They behave identically to levers in that case. But this doesn't happen when the crank changes power level otherwise

commented

i dont understands. Does this mean levers too dont work with that block? are their changes picked up by relayers or observers?

commented

okay let me send a video

commented

what i mean is since cranks are just a analog verson of levers and their code is basically the same, if cranks have a problem it implies levers have the same problem too. So how come that is my problem? this would be even more relevant if that redstone update is being picked up by other blocks like repeaters, observers and relayers

commented

I've just tested and I cant replicate. Cranks are able to update both repeaters, redstone dust, comparators, observers, relayers, redstone lamps, illuminators, cog blocks, pistons and whatever other blocks thats placed next or behind them.
All this points toward an issue thats not on my side like ive stated before given their code is same as levers

commented

Imageall these work fine for me, i could try more and more but i dont expect them to misbehave or behave different than a lever would

commented

https://github.com/team-abnormals/caverns-and-chasms/blob/1.20.x/src/main/java/com/teamabnormals/caverns_and_chasms/common/block/ResistorBlock.java

I'm going to reopen the issue I made in the C&C repo. Above is the code of resistors, do you see anything wrong that jumps out at you

commented

at most flipped direction but idk. checking should be easy tho, just place a lever behind it

commented

btw if you do this you bascailly have a resistor

Image
commented

im also fixing the bug where you need a wire in between

commented

you need a wire in between for levers as well

commented
8mb.video-FRV-6IpBv9SJ.mp4
commented

yeah your video confirms. 100% their issue. it updates their block fine. what their block does isnt up to me. its output power is not up to me