Supplementaries

Supplementaries

Mods
127M Downloads

[🐞]: Recipe Issue - Malformed way_sign recipes causing KubeJS errors Neoforge 1.21.1

darklotus781 opened this issue · 0 comments

commented

Before Continuing:

  • Check you are using the latest version of the mods and its dependencies
  • Always include a latest.log if you are crashing
  • Remove known hacky mods such as: Optifine, Fabric API/Connector on forge, and every kind of hybrid server like Mohist and Velocity. None of these are supported. Also try without other lesser usual suspects like Sodium and Lithium.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version

1.21.1-NEOFORGE

Supplementaries Version

1.21-3.4.20-neoforge

Moonlight Lib Version

1.21-2.25.5-neoforge

Describe Issue

I'm having the same issue someone else was having that you claimed was a datapack issue, however I strongly disagree.
NeoForge 21.1.209 / Supplementaries 1.21-3.4.20-neoforge
I have ZERO datapacks touching the supplementaries namespace, I even disabled way signs in the config.

This is 100% a mod issue and the way you chose to handle the recipes for 1.21.1. You can't use that same format in Common for Fabric / Forge / Neoforge.

https://github.com/MehVahdJukaar/Supplementaries/blob/1.21/common/src/main/resources/data/supplementaries/recipe/way_sign_oak/minecraft/mangrove.json

{
  "category": "misc",
  "result": {
    "id": "supplementaries:way_sign_mangrove",
    "count": 2
  },
  "ingredients": [
    {
      "ingredient": {
        "item": "minecraft:oak_sign"
      },
      "block_type": "minecraft:wood_type",
      "from": "minecraft:oak",
      "to": "minecraft:mangrove",
      "fabric:type": "moonlight:block_type_swap"
    }
  ],
  "type": "minecraft:crafting_shapeless"
}

For Neoforge, it should be formatted like this

{
  "type": "minecraft:crafting_shapeless",
  "category": "misc",
  "ingredients": [
    {
      "item": "minecraft:oak_sign"
    }
  ],
  "result": {
    "id": "supplementaries:way_sign_mangrove",
    "count": 2
  }
}

This is from my logs/kubejs/server.log:

[11:59:32] [ERROR] ! RegistryAccessContainer.java#519: Failed to read ingredients:unwrapped_ingredient_list from recipe supplementaries:way_sign_oak/minecraft/mangrove[minecraft:crafting_shapeless]: java.lang.IllegalStateException: Failed to parse either. First: Not a json array: {"ingredient":{"item":"minecraft:oak_sign"},"block_type":"minecraft:wood_type","from":"minecraft:oak","to":"minecraft:mangrove","fabric:type":"moonlight:block_type_swap"}; Second: No key tag in MapLike[{"ingredient":{"item":"minecraft:oak_sign"},"block_type":"minecraft:wood_type","from":"minecraft:oak","to":"minecraft:mangrove","fabric:type":"moonlight:block_type_swap"}]; No key item in MapLike[{"ingredient":{"item":"minecraft:oak_sign"},"block_type":"minecraft:wood_type","from":"minecraft:oak","to":"minecraft:mangrove","fabric:type":"moonlight:block_type_swap"}]
[11:59:32] [ERROR] ! java.lang.IllegalStateException: Failed to parse either. First: Not a json array: {"ingredient":{"item":"minecraft:oak_sign"},"block_type":"minecraft:wood_type","from":"minecraft:oak","to":"minecraft:mangrove","fabric:type":"moonlight:block_type_swap"}; Second: No key tag in MapLike[{"ingredient":{"item":"minecraft:oak_sign"},"block_type":"minecraft:wood_type","from":"minecraft:oak","to":"minecraft:mangrove","fabric:type":"moonlight:block_type_swap"}]; No key item in MapLike[{"ingredient":{"item":"minecraft:oak_sign"},"block_type":"minecraft:wood_type","from":"minecraft:oak","to":"minecraft:mangrove","fabric:type":"moonlight:block_type_swap"}]
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/com.mojang.serialization.DataResult$Error.getOrThrow(DataResult.java:287)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/com.mojang.serialization.DataResult.getOrThrow(DataResult.java:81)
[11:59:32] [ERROR] !   at …kubejs.util.RegistryAccessContainer.wrapOperation$cel000$kubejstweaks$kjstweaks$throwProperly(RegistryAccessContainer.java:519)
[11:59:32] [ERROR] !   at …kubejs.util.RegistryAccessContainer.decodeJson(RegistryAccessContainer.java:150)
[11:59:32] [ERROR] !   at …kubejs.recipe.component.RecipeComponent.readFromJson(RecipeComponent.java:139)
[11:59:32] [ERROR] !   at …kubejs.recipe.KubeRecipe.deserialize(KubeRecipe.java:78)
[11:59:32] [ERROR] !   at …kubejs.recipe.schema.RecipeSchema.deserialize(RecipeSchema.java:255)
[11:59:32] [ERROR] !   at …kubejs.recipe.RecipesKubeEvent.parseOriginalRecipe(RecipesKubeEvent.java:241)
[11:59:32] [ERROR] !   at …kubejs.recipe.RecipesKubeEvent.discoverRecipes(RecipesKubeEvent.java:219)
[11:59:32] [ERROR] !   at …kubejs.recipe.RecipesKubeEvent.post(RecipesKubeEvent.java:179)
[11:59:32] [ERROR] !   at net.minecraft.world.item.crafting.RecipeManager.handler$egj000$kubejs$customRecipesHead(RecipeManager.java:6077)
[11:59:32] [ERROR] !   at net.minecraft.world.item.crafting.RecipeManager.apply(RecipeManager.java)
[11:59:32] [ERROR] !   at net.minecraft.world.item.crafting.RecipeManager.apply(RecipeManager.java:36)
[11:59:32] [ERROR] !   at net.minecraft.server.packs.resources.SimplePreparableReloadListener.lambda$reload$1(SimplePreparableReloadListener.java:19)
[11:59:32] [ERROR] !   at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source)
[11:59:32] [ERROR] !   at java.util.concurrent.CompletableFuture$Completion.run(Unknown Source)
[11:59:32] [ERROR] !   at net.minecraft.server.packs.resources.SimpleReloadInstance.lambda$new$3(SimpleReloadInstance.java:69)
[11:59:32] [ERROR] !   at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:148)
[11:59:32] [ERROR] !   at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23)
[11:59:32] [ERROR] !   at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122)
[11:59:32] [ERROR] !   at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:132)
[11:59:32] [ERROR] !   at net.minecraft.client.Minecraft.managedBlock(Minecraft.java:4518)
[11:59:32] [ERROR] !   at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.loadWorldDataBlocking(WorldOpenFlows.java:201)
[11:59:32] [ERROR] !   at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.loadWorldStem(WorldOpenFlows.java:142)
[11:59:32] [ERROR] !   at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.openWorldLoadLevelStem(WorldOpenFlows.java:346)
[11:59:32] [ERROR] !   at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.openWorldCheckVersionCompatibility(WorldOpenFlows.java:335)
[11:59:32] [ERROR] !   at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.openWorldLoadLevelData(WorldOpenFlows.java:297)
[11:59:32] [ERROR] !   at net.minecraft.client.gui.screens.worldselection.WorldOpenFlows.openWorld(WorldOpenFlows.java:261)
[11:59:32] [ERROR] !   at net.minecraft.client.gui.screens.worldselection.WorldSelectionList$WorldListEntry.joinWorld(WorldSelectionList.java:498)
[11:59:32] [ERROR] !   at net.minecraft.client.gui.screens.worldselection.WorldSelectionList$WorldListEntry.mouseClicked(WorldSelectionList.java:481)
[11:59:32] [ERROR] !   at net.minecraft.client.gui.components.AbstractSelectionList.mouseClicked(AbstractSelectionList.java:315)
[11:59:32] [ERROR] !   at net.minecraft.client.gui.components.events.ContainerEventHandler.mouseClicked(ContainerEventHandler.java:38)
[11:59:32] [ERROR] !   at net.minecraft.client.MouseHandler.lambda$onPress$0(MouseHandler.java:98)
[11:59:32] [ERROR] !   at net.minecraft.client.gui.screens.Screen.wrapScreenError(Screen.java:451)
[11:59:32] [ERROR] !   at net.minecraft.client.MouseHandler.onPress(MouseHandler.java:95)
[11:59:32] [ERROR] !   at net.minecraft.client.MouseHandler.lambda$setup$4(MouseHandler.java:202)
[11:59:32] [ERROR] !   at net.minecraft.util.thread.BlockableEventLoop.execute(BlockableEventLoop.java:98)
[11:59:32] [ERROR] !   at net.minecraft.client.MouseHandler.lambda$setup$5(MouseHandler.java:202)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]+5/org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]+5/org.lwjgl.system.JNI.invokeV(Native Method)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]+5/org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3509)
[11:59:32] [ERROR] !   at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:162)
[11:59:32] [ERROR] !   at net.minecraft.client.Minecraft.runTick(Minecraft.java:1220)
[11:59:32] [ERROR] !   at net.minecraft.client.Minecraft.run(Minecraft.java:807)
[11:59:32] [ERROR] !   at net.minecraft.client.main.Main.main(Main.java:230)
[11:59:32] [ERROR] !   at java.lang.reflect.Method.invoke(Unknown Source)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:136)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:124)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonClientLaunchHandler.runService(CommonClientLaunchHandler.java:32)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.lambda$launchService$4(CommonLaunchHandler.java:118)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:103)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:74)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26)
[11:59:32] [ERROR] !   at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23)
[11:59:32] [ERROR] !   at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.run(BootstrapLauncher.java:210)
[11:59:32] [ERROR] !   at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:69)
[11:59:32] [WARN] KubeRecipe.java#88: Failed to parse recipe 'supplementaries:way_sign_oak/minecraft/mangrove[minecraft:crafting_shapeless]'! Falling back to vanilla: Recipe component key 'ingredients' not found! Valid keys: [result:item_stack, ingredients:unwrapped_ingredient_list, category?:crafting_book_category] - java.lang.IllegalStateException: Failed to parse either. First: Not a json array: {"ingredient":{"item":"minecraft:oak_sign"},"block_type":"minecraft:wood_type","from":"minecraft:oak","to":"minecraft:mangrove","fabric:type":"moonlight:block_type_swap"}; Second: No key tag in MapLike[{"ingredient":{"item":"minecraft:oak_sign"},"block_type":"minecraft:wood_type","from":"minecraft:oak","to":"minecraft:mangrove","fabric:type":"moonlight:block_type_swap"}]; No key item in MapLike[{"ingredient":{"item":"minecraft:oak_sign"},"block_type":"minecraft:wood_type","from":"minecraft:oak","to":"minecraft:mangrove","fabric:type":"moonlight:block_type_swap"}]