Supplementaries

Supplementaries

Mods
127M Downloads

[🐞]: Missing way sign recipe for every wood type except oak

edgarogh opened this issue · 0 comments

commented

Before Continuing:

  • Check you are using the latest version of the mods and its dependencies
  • Always include a latest.log if you are crashing
  • Remove known hacky mods such as: Optifine, Fabric API/Connector on forge, and every kind of hybrid server like Mohist and Velocity. None of these are supported. Also try without other lesser usual suspects like Sodium and Lithium.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version

1.21.1-NEOFORGE

Supplementaries Version

1.21-3.5.0alpha

Moonlight Lib Version

1.21-2.26.1

Describe Issue

It is impossible to craft way/road signs except oak.

There are probably 2 problems that cause this:

  1. the fallback recipe is chosen even when a sign block exists for the current wood type (see below)
  2. #1754 causes the fallback recipe to not work properly

For problem ①, from what I understand, the following piece of code tries to create a recipe "normal sign -> 2x way sign" iff a sign block exists for the given wood type:

Supplementaries/common/src/main/java/net/mehvahdjukaar/supplementaries/dynamicpack/ModServerDynamicResources.java

Lines 153 to 154 in 2875e77

ResourceLocation recipeTemplate = w.getChild("sign") == null ?
Supplementaries.res("way_sign_oak") : Supplementaries.res("way_sign_mod_template");

But the condition is wrong/inverted: it should be w.getChild("sign") != null instead.

And for problem ②, as mentioned in the other issue, it seems like the generated recipe has a wrong JSON format and can't be loaded.