Supplementaries

Supplementaries

110M Downloads

[Fabric] Crash with Colormatic and Advancement Frames

SplendidAlakey opened this issue ยท 3 comments

commented

MC 1.19.2
FAPI 0.60.0
Moonlight Lib 2.0.17
Supplementaries 2.0.14
Advancement Frames 1.1.2
Colormatic 3.1.2

To reproduce simply install all the mods and launch the game.

A similar issue was reported to Colormatic here: kvverti/colormatic#107. According to the dev, it was caused by the affected mod registering its objects too late for Fabric.

Quilt is unaffected.

Logs: https://gist.github.com/Footage2-Amply-Pounce/8a9470e5592cb03acd00972e7ec7c415

commented

Colormatic should not affect registries in any way.

commented

Hm so you have forge events to register stuff on forge but on fabric registration does not have a set place where it can happen, infact is very more often than not based off classloading static initialization which could very well happen not on mod init. Here I'm registering my stiff right after mod init. I too make the assumption that blocks would have been registered in mod init and infact the reason I register right after is so I can iterate over existing blocks to register my dynamic blocks which are based off existing ones (for every compat for example) however if a mod would not follow this nothing harmful would happen. I actually thing it is a colormatic issue as fabric does not have any designated place for registration and so they should make their code safe to run even if stuff gets registered outside of mod init. That's actually one of the reason why forge forces you to register stuff in very specific time frames

commented

Fixed on the latest version of MoonLight.